Skip to content

[DM/FEATURE] Generic block layer #9590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2024
Merged

[DM/FEATURE] Generic block layer #9590

merged 3 commits into from
Nov 20, 2024

Conversation

GuEe-GUI
Copy link
Contributor

@GuEe-GUI GuEe-GUI commented Oct 30, 2024

拉取/合并请求描述:(PR description)

[

  1. Disk and blk device management.
  2. Support partitions probe auto.
  3. Support DFS and user mode fops, ioctl.
  4. Add a cmd for blk info.
  5. port to the block for SDIO.
  6. remove SDIO rt_mmcsd_blk_init
  7. remove SDIO gpt

Depends on: #9573
Depends on: #9594

  • BSP:
    qemu-vexpress-a9
    qemu-virt64-aarch64
    rockchip/rk3568

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

1. Disk and blk device management.
2. Support partitions probe auto.
3. Support DFS and user mode fops, ioctl.
4. Add a cmd for blk info.

Signed-off-by: GuEe-GUI <[email protected]>
1. remove gpt.
2. remove block device custom.

Signed-off-by: GuEe-GUI <[email protected]>

#include <rthw.h>
#include <rtthread.h>
#include <drivers/blk.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块#include rtdevice.h就行

Copy link
Contributor Author

@GuEe-GUI GuEe-GUI Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分存在dfs和device头文件相互依赖的冲突,所以需要单独导入,才能访问结构体成员:

#ifndef __DFS_H__
#include <dfs_fs.h>

struct rt_blk_device
{
    struct rt_device parent;

    int partno;
    struct dfs_partition partition;

    rt_list_t list;
    struct rt_blk_disk *disk;

    rt_size_t sector_start;
    rt_size_t sector_count;
};
#else
struct rt_blk_device;
#endif /* __DFS_H__ */

#include <rthw.h>
#include <rtthread.h>
#include <drivers/blk.h>
#include <drivers/misc.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个头文件是不是忘记加到 rtdevice.h 里面了?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原因和上面是一样的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

明白了

@Rbb666 Rbb666 merged commit 5dda65c into RT-Thread:master Nov 20, 2024
45 of 46 checks passed
@GuEe-GUI GuEe-GUI deleted the block branch November 21, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants