Skip to content

Bug appears when using 3.1.1. #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petrbrzek opened this issue Jul 28, 2016 · 6 comments
Closed

Bug appears when using 3.1.1. #158

petrbrzek opened this issue Jul 28, 2016 · 6 comments

Comments

@petrbrzek
Copy link
Contributor

petrbrzek commented Jul 28, 2016

This didn't happen with the previous version.

TypeError: Cannot read property 'l' of undefined
  at getTipOffsetLeft (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/avocode-ui/node_modules/react-tooltip/dist/utils/getPosition.js:35:40)
  at exports.default (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/avocode-ui/node_modules/react-tooltip/dist/utils/getPosition.js:170:22)
  at ReactTooltip.updatePosition (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/avocode-ui/node_modules/react-tooltip/dist/index.js:398:46)
  at ReactTooltip.<anonymous> (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/avocode-ui/node_modules/react-tooltip/dist/index.js:320:20)
  at CallbackQueue.notifyAll (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/CallbackQueue.js:65:22)
  at ReactUpdatesFlushTransaction.close (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdates.js:57:24)
  at ReactUpdatesFlushTransaction.closeAll (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/Transaction.js:202:25)
  at ReactUpdatesFlushTransaction.perform (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/Transaction.js:149:16)
  at ReactUpdatesFlushTransaction.perform (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdates.js:86:38)
  at Object.flushBatchedUpdates (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdates.js:147:19)
  at Object.wrapper [as flushBatchedUpdates] (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactPerf.js:66:21)
  at ReactDefaultBatchingStrategyTransaction.closeAll (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/Transaction.js:202:25)
  at ReactDefaultBatchingStrategyTransaction.perform (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/Transaction.js:149:16)
  at Object.batchedUpdates (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactDefaultBatchingStrategy.js:62:19)
  at Object.enqueueUpdate (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdates.js:176:22)
  at enqueueUpdate (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdateQueue.js:24:16)
  at Object.enqueueCallback (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactUpdateQueue.js:108:5)
  at ReactTooltip.ReactComponent.setState (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/react/lib/ReactComponent.js:67:18)
  at updateState (/Users/petrbrzek/Desktop/dev/forked-repos/avocode/node_modules/avocode-ui/node_modules/react-tooltip/dist/index.js:315:18)
@wwayne
Copy link
Collaborator

wwayne commented Jul 28, 2016

Weird, that should be fixed in 3.1.1, can you show me more about your code?

@cesarwbr
Copy link

You can see this problem in sample page: http://wwayne.com/react-tooltip/
I think the error happens when you scroll during the tooltip

@wwayne
Copy link
Collaborator

wwayne commented Jul 29, 2016

Hm, I see it, thanks, will have a deep investigation

@maullerz
Copy link

Have this error also,
in #150 when i use delayShow and remove cursor from element while tooltip didnt appear yet.

@caesarsol
Copy link

caesarsol commented Jul 29, 2016

I'm having the same problem here, exactly described by @maullerz.

@wwayne I've found that state.place === "", that causes the error in getTipOffsetLeft() when called with empty string.

@petrbrzek: the title of this Issue could be more describing, like "Cannot read property 'l' of undefined", would you update it?

wwayne added a commit that referenced this issue Jul 30, 2016
wwayne added a commit that referenced this issue Jul 30, 2016
Fix for #158, getposition error
@wwayne
Copy link
Collaborator

wwayne commented Jul 30, 2016

I picked a wrong way to fix #143, this should be fixed in 3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants