Skip to content

Support more placement options in TooltipTypes.d.ts #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2023

Conversation

colynfulcrum
Copy link
Contributor

Support more place types that floating-ui supports. These actually already work but I need the type to be updated to reflect existing allowed types.

Support more place types that floating-ui supports. These actually already work but I need the type to be updated to reflect existing allowed types.
@gabrieljablonski
Copy link
Member

gabrieljablonski commented Jun 23, 2023

Thanks for suggesting this. Before we can merge this, we have to update a few more files.

Source:

  • src/utils/compute-positions-types.d.ts

Docs:

  • docs/options.mdx
  • docs/examples/place.mdx

I believe I haven't missed any. Feel free to update them, or leave it to us for whenever we get the time.

Updated types on place
Added more place types
Updated place example to include more types
@colynfulcrum
Copy link
Contributor Author

Thanks for suggesting this. Before we can merge this, we have to update a few more files.

Source:

  • src/utils/compute-positions-types.d.ts

Docs:

  • docs/options.mdx
  • docs/examples/place.mdx

I believe I haven't missed any. Feel free to update them, or leave it to us for whenever we get the time.

I've updated those files. Hope that works. Have a great weekend!

@colynfulcrum
Copy link
Contributor Author

@gabrieljablonski sorry, I missed a big section in the docs. I will get to this later tonight.

image

Updated examples to include more placement types
@colynfulcrum
Copy link
Contributor Author

@gabrieljablonski I updated the examples to include the other types... see screen recording

Screen.Recording.2023-06-24.at.9.43.46.AM.mov

@danielbarion danielbarion merged commit 0f9cdb3 into ReactTooltip:master Jun 27, 2023
@danielbarion
Copy link
Member

Available at v5.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants