Skip to content

Fix useLayoutEffect warning with SSR #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix useLayoutEffect warning with SSR #956

merged 1 commit into from
Feb 22, 2023

Conversation

gabrieljablonski
Copy link
Member

Closes #954

@gabrieljablonski gabrieljablonski self-assigned this Feb 22, 2023
danielbarion
danielbarion approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@danielbarion danielbarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched the issue, code looks good to me.

@gabrieljablonski gabrieljablonski merged commit d6c7d0d into master Feb 22, 2023
@gabrieljablonski gabrieljablonski deleted the fix/use-layout-effect-ssr branch February 22, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbarion danielbarion danielbarion approved these changes

Assignees

@gabrieljablonski gabrieljablonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] useLayoutEffect warning in dev mode
2 participants
@gabrieljablonski @danielbarion