Skip to content

add mouseUp and mouseDown #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add mouseUp and mouseDown #4

wants to merge 1 commit into from

Conversation

stephenkingsley
Copy link

I think add mouseUp and mouseDown event is convenient for this project.

@mjackson
Copy link
Member

mjackson commented Aug 6, 2016

Why do you think this change is necessary? Can't you just add these events directly to your child component?

<PointTarget ...>
  <div onMouseUp={...}/>
</PointTarget>

@mjackson mjackson closed this Aug 6, 2016
@stephenkingsley
Copy link
Author

because in the PointTarget had click event, so mouseUp or down is a part of click event.

@mjackson
Copy link
Member

mjackson commented Aug 6, 2016

@stephenkingsley We're just cloning whatever element you give us and passing in an onClick prop. If you want to use onMouseUp or onMouseDown you can do so using the example above.

@mjackson mjackson reopened this Aug 6, 2016
@mjackson mjackson closed this Aug 6, 2016
@stephenkingsley
Copy link
Author

may I ask you what is the purpose of creating PointTarget. just the click event?

@battaile
Copy link

battaile commented Aug 7, 2016

@stephenkingsley #2

@stephenkingsley
Copy link
Author

maybe I knew what is the purpose of this component. and I agree it that the component is not need other event. and if I want to join your group, has any problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants