Skip to content

fix windows compile #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

BumbleB2na
Copy link

@BumbleB2na BumbleB2na commented Apr 7, 2021

PR

Allows compile of exercise or lectures on Windows 10. Fix for Issue: #33

Testing considerations

  • was tested using powershell, using same environment as described in issue below
  • was not tested on mac
  • was not tested on linux

Bug

On Windows npm start from cmd or powershell will only compile the full app (ie: either YesterTech or ProjectPlanner) to localhost:3000.

Expected result:

It compiles the chosen exercise/lecture to localhost:3000

Note: Installing WSL on Windows is suggested in Readme.md

Environment:

Windows 10 with latest updates. Either latest Chrome or latest Edge browser. Latest node.js LTS with latest npm.

Note: I do not have WSL[2] installed as suggested in the Readme.md

Steps to reproduce:

  1. open powershell on windows in project directory
  2. enter command npm start
  3. make choices in terminal that lead to webpack compile of an exercise
  4. navigate to localhost:3000 in web browser

or: enter npm start core-v1 1 and enter 1 for 'exercise'
or: enter npm start core-v2 1 and enter 1 for 'exercise'

@bradwestfall
Copy link
Collaborator

Thanks for all this, I just haven't had a second to test it out yet. I hope to this week

@BumbleB2na
Copy link
Author

Found an issue: this PR so far doesn't properly override files other than index.tsx. I have a change coming shortly that fixes that and just need a bit more time to push.

@BumbleB2na BumbleB2na closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants