2.x: fix flatMapX calling SpscLinkedArrayQueue.offer concurrently #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.18% (diff: 66.66%)@@ 2.x #4678 diff @@
==========================================
Files 565 565
Lines 37414 37426 +12
Methods 0 0
Messages 0 0
Branches 5746 5746
==========================================
+ Hits 30698 30759 +61
+ Misses 4626 4586 -40
+ Partials 2090 2081 -9
|
JakeWharton
approved these changes
Oct 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to synchronize the offer part of the new flatMapX operators (since of course, Spsc is for single producer only but here there could be concurrent non fast-path queueing of values).
(There is an MpscLinkedArrayQueue in JCTools but I'm not confident in it and don't want to use MpscLinkedQueue due to the node allocation.)