Skip to content

VULN-1923 fix: allow kebab actions if the selected item is filtered out #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

tkasparek
Copy link
Contributor

unifying behavior with systems exposed table where status can be edited via kebab action if the selected item is filtered out

@jira-linking
Copy link

jira-linking bot commented Sep 13, 2021

Referenced Jiras:
https://issues.redhat.com/browse/VULN-1923

Copy link
Member

@leSamo leSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the branch name 😂 looks good, but let's fix everything while we're at it.

When you have items selected and table empty:

  • Exposed systems table:
    • remediation button should be enabled
    • export button should be grayed out
  • System detail table:
    • remediation button should be enabled
    • actions should be enabled

Also looks like snapshots are failing because you have incorrect PF version, try:

rm -rf dist
rm -rf node_modules
npm i
npm run test -- -u

VULN-1923
unifying behavior with systems exposed table where status can be edited
via kebab action if the selected item is filtered out
@tkasparek
Copy link
Contributor Author

@leSamo I've fixed export button on exposed systems page and enabled actions on system detail page.
Regarding remediation button - I have a feeling that it might be more complicated than it feels and we might need to have some discussion about that from brief investigation of the Remediation component so I'd prefer to address it as a separate ticket.

@tkasparek tkasparek requested a review from leSamo September 13, 2021 13:27
Copy link
Member

@leSamo leSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki doki, I've created a ticket for the remediation button, so we won't forget about it: https://issues.redhat.com/browse/VULN-1932

@leSamo leSamo merged commit be94181 into RedHatInsights:master Sep 13, 2021
kpatticha pushed a commit that referenced this pull request Sep 13, 2021
## [1.77.7](v1.77.6...v1.77.7) (2021-09-13)

### Bug Fixes

* allow kebab actions if the selected item is filtered out ([#1204](#1204)) ([be94181](be94181))
@kpatticha
Copy link
Contributor

🎉 This PR is included in version 1.77.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Kinlaw pushed a commit to RedHatInsights/vulnerability-ui-build that referenced this pull request Sep 13, 2021
## [1.77.7](RedHatInsights/vulnerability-ui@v1.77.6...v1.77.7) (2021-09-13)

### Bug Fixes

* allow kebab actions if the selected item is filtered out ([#1204](RedHatInsights/vulnerability-ui#1204)) ([be94181](RedHatInsights/vulnerability-ui@be94181))
Kinlaw pushed a commit to RedHatInsights/vulnerability-ui-build that referenced this pull request Sep 13, 2021
## [1.77.7](RedHatInsights/vulnerability-ui@v1.77.6...v1.77.7) (2021-09-13)

### Bug Fixes

* allow kebab actions if the selected item is filtered out ([#1204](RedHatInsights/vulnerability-ui#1204)) ([be94181](RedHatInsights/vulnerability-ui@be94181))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants