-
Notifications
You must be signed in to change notification settings - Fork 53
VULN-1923 fix: allow kebab actions if the selected item is filtered out #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Referenced Jiras: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the branch name 😂 looks good, but let's fix everything while we're at it.
When you have items selected and table empty:
- Exposed systems table:
- remediation button should be enabled
- export button should be grayed out
- System detail table:
- remediation button should be enabled
- actions should be enabled
Also looks like snapshots are failing because you have incorrect PF version, try:
rm -rf dist
rm -rf node_modules
npm i
npm run test -- -u
VULN-1923 unifying behavior with systems exposed table where status can be edited via kebab action if the selected item is filtered out
7f4a546
to
e816d89
Compare
@leSamo I've fixed export button on exposed systems page and enabled actions on system detail page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki doki, I've created a ticket for the remediation button, so we won't forget about it: https://issues.redhat.com/browse/VULN-1932
## [1.77.7](v1.77.6...v1.77.7) (2021-09-13) ### Bug Fixes * allow kebab actions if the selected item is filtered out ([#1204](#1204)) ([be94181](be94181))
🎉 This PR is included in version 1.77.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [1.77.7](RedHatInsights/vulnerability-ui@v1.77.6...v1.77.7) (2021-09-13) ### Bug Fixes * allow kebab actions if the selected item is filtered out ([#1204](RedHatInsights/vulnerability-ui#1204)) ([be94181](RedHatInsights/vulnerability-ui@be94181))
## [1.77.7](RedHatInsights/vulnerability-ui@v1.77.6...v1.77.7) (2021-09-13) ### Bug Fixes * allow kebab actions if the selected item is filtered out ([#1204](RedHatInsights/vulnerability-ui#1204)) ([be94181](RedHatInsights/vulnerability-ui@be94181))
unifying behavior with systems exposed table where status can be edited via kebab action if the selected item is filtered out