Skip to content

add immediate sibiling to parent op #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

AviAvni
Copy link
Contributor

@AviAvni AviAvni commented Jan 9, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #158 (031786c) into master (763cad5) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   85.44%   85.53%   +0.08%     
==========================================
  Files           9        9              
  Lines         646      650       +4     
==========================================
+ Hits          552      556       +4     
  Misses         94       94              
Impacted Files Coverage Δ
redisgraph/execution_plan.py 81.44% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 763cad5...031786c. Read the comment docs.

@@ -164,7 +164,11 @@ def _create_operation(args):
if op_level == level:
# if the operation level equal to the current level
# set the current operation and move next
current = _create_operation(current_op.split("|"))
child = _create_operation(current_op.split("|"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test which will cover this case.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swilly22 swilly22 merged commit 3afea24 into master Jan 11, 2022
@swilly22 swilly22 deleted the fix-structure-plan-bug branch January 11, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants