close #43. Changed graph creation and docs. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 6 6
Lines 106 106
Branches 6 6
=======================================
Hits 96 96
Misses 10 10Continue to review full report at Codecov.
|
DvirDukhan
force-pushed
the
issue43
branch
3 times, most recently
from
37424ce to
e51de6a
Compare
gkorland
suggested changes
Mar 1, 2020
src/graph.js
Outdated
| * @param {ClientOpts} [configuration.options] node_redis options | ||
| */ | ||
| constructor(graphId, {host, port, options} ={}) { | ||
| console.log("host = " + host + " port = " + port + " options = "+ options); |
There was a problem hiding this comment.
@DvirDukhan "console.log"?
src/graph.js
Outdated
| * @param {string | int} [configuration.port] Redis port | ||
| * @param {ClientOpts} [configuration.options] node_redis options | ||
| */ | ||
| constructor(graphId, {host, port, options} ={}) { |
There was a problem hiding this comment.
@DvirDukhan doesn't it create a breaking change? and which versions of nodejs support this syntax?
gkorland
reviewed
Mar 4, 2020
test/redisGraphAPITest.js
Outdated
| @@ -16,8 +16,21 @@ describe("RedisGraphAPI Test", () => { | |||
| return api.deleteGraph().catch(() => {}); | |||
| }); | |||
|
|
|||
| it("test bring your client", () => { | |||
| return new RedisGraph("social", redis.createClient()); | |||
| it("test connection from post and host", async () => { | |||
gkorland
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.