cmake: Use upstream helpers for the Config.cmake file #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
3 times, most recently
from
b2a2c71 to
d9af4c5
Compare
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
from
d9af4c5 to
aaa2c4f
Compare
Signed-off-by: Cristian Le <[email protected]>
Use the current binary dir instead. Use `configure_file` to guarantee the project is reconfigured when these files change. Not in this commit, fixing the working directory and references of the tests Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
LecrisUT
force-pushed
the
cmake/refactor/cmake-config
branch
from
aaa2c4f to
5618e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in the refactoring series. Use modern design for creating the
Config.cmakefile.Depends-on: #123, #125
Fixes #109
(Mostly, the targets created and exported are still not visible, but I want to address that in another PR that focuses on readability, which would be the last in the series)