Hotfix: Rebase PR #2 #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit turns on `-Wdeprecated` in the test suite and fixes several associated deprecation warnings that show up as a result: - in C++17 `static constexpr` members are implicitly inline; our redeclaration (needed for C++11/14) is deprecated in C++17. - various test suite classes have destructors and rely on implicit copy constructors, but implicit copy constructor definitions when a user-declared destructor is present was deprecated in C++11. - Eigen also has various implicit copy constructors, so just disable `-Wdeprecated` in `eigen.h`.
This changes the travis-ci eigen download code to extract the tar on the fly (rather than saving to a file first), and extracts into an `eigen` directory rather than using upstream's `eigen-eigen-xxxxx` directory. This also bumps the travis-ci eigen release to 3.3.4, in an attempt to see if it fixed the -Wdeprecated warnings (it did not); the build setup cleanup seems worth committing anyway.
None of the three currently recommended approaches works on PyPy, due to it not garbage collecting things when you want it to. Added a note with example showing how to get interpreter shutdown callbacks using the Python atexit module.
Pybind11's default conversion to int always produces a long on Python 2 (`int`s and `long`s were unified in Python 3). This patch fixes `int` handling to match Python 2 on Python 2; for short types (`size_t` or smaller), the number will be returned as an `int` if possible, otherwise `long`. Requires Python 2.5+. This is needed for things like `sys.exit`, which refuse to accept a `long`.
EricCousineau-TRI
force-pushed
the
hotfix/2_rebase
branch
2 times, most recently
from
7446a87 to
d0f597a
Compare
EricCousineau-TRI
force-pushed
the
hotfix/2_rebase
branch
from
d0f597a to
4d6b15e
Compare
…` and `unique_ptr<T>` for pure C++ instances and single-inheritance instances
EricCousineau-TRI
force-pushed
the
hotfix/2_rebase
branch
from
4d6b15e to
48999b6
Compare
|
Document test results before closing: https://travis-ci.org/RobotLocomotion/pybind11/builds/319878121?utm_source=github_status&utm_medium=notification |
|
Finished tasks. |
|
After everything was said and done: Tested rebuilding on |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rebases PR #2 on top of latest
pybind11:master(sha:a303c6f).This is meant for testing CI. If approved:
drakeis in new branch,no_prune: 433a6c7upstreamfrom0a0758ctoa303c6fdrake(from433a6c7to48999b6)no_prunelast_sha_of_previous_fork(6d72785) intono_prunewithmerge --no-ff --strategy=ours: 3471f54last_sha_of_previous_forkfrom6d72785toffcf754\cc @m-chaturvedi @jamiesnape