Improvements to AC calculations & display & others #1751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DameryDad
commented
May 21, 2023
DameryDad
commented
- Fixed issues with checking AC for TotalAC item types.
- Added data attribute to suppress a character's dexterity bonus.
- Added warning if trying to change weapon when holding a cursed weapon.
- Support weapons and magic item attacks that use multiple power charges.
- Added ac combination rules to MI database data specifications.
- Fixed ac support for magic helms.
- Support the item charge type 'single-uncharged' for charged items with non-standard discharging mechanisms.
- Display the ac mod effect of each valid item on the Check AC dialog.
- Fix --mod-weap command selection of specified weapons for mod-ing.
* Fixed issues with checking AC for TotalAC item types. * Added data attribute to suppress a character's dexterity bonus. * Added warning if trying to change weapon when holding a cursed weapon. * Support weapons and magic item attacks that use multiple power charges. * Added ac combination rules to MI database data specifications. * Fixed ac support for magic helms. * Support the item charge type 'single-uncharged' for charged items with non-standard discharging mechanisms. * Display the ac mod effect of each valid item on the Check AC dialog. * Fix --mod-weap command selection of specified weapons for mod-ing.
|
Can I check if this Pull Request is likely to go live in the next few days? I appreciate it's quite a large release in terms of the number of changes. Request made weekend of 20/21st May, so somewhat surprised the RPGMaster v1.5.01 release didn't go at the start of the week. If there is anything wrong with the release, please do let me know, or perhaps the regular merge date (used to be Tuesday morning) has changed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.