TEMP: add debug logging for API conversation history issues #4312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add detailed logging to readApiMessages function to help diagnose "Unexpected: No existing API conversation history" errors. The logs will show: - When the history file exists but contains an empty array - When the old history file exists but contains an empty array - When neither history file is found This will help diagnose issues like the one in #4311 where the API conversation history file gets truncated to an empty array during task resumption with orchestrator tasks. Fixes: #4311 Signed-off-by: Eric Wheeler <[email protected]>
dosubot
bot
added
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
dosubot
bot
added
size:M
Add error handling for JSON parsing failures in readApiMessages: - Wrap JSON.parse calls in try/catch blocks for both current and legacy history files - Add detailed error logging with taskId and file paths - Return empty arrays when parsing fails to maintain function contract - Improve existing debug logging for empty history arrays - Handle file unlinking even when parsing fails This prevents crashes from malformed JSON in history files and provides better debugging information when API conversation history is corrupted. Related to issue #4311. Signed-off-by: Eric Wheeler <[email protected]>
KJ7LNW
force-pushed
the
debug-api-conversation-history
branch
from
21a8167 to
9d19c68
Compare
hannesrudolph
changed the title
|
See notes on the issue as to why I moved this to draft |
|
You can leave us in draft if you want, this is not something I am going to put more work into. I just wanted to provide the steps I took for troubleshooting and case it helps someone else along the way. These debug prints are non-intrusive, uncommon, only trigger upon error, and only serve to help troubleshoot this problem if somebody else hits it. IMHO, PRs like this should be merged quickly to help future troubleshooting by others. (Someday if I clean up and delete the branch, then this research could be lost.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds detailed debug logging to the
readApiMessagesfunction to help diagnose "Unexpected: No existing API conversation history" errors.Implementation
Added logging for three scenarios:
How to Test
When encountering the "Unexpected: No existing API conversation history" error, check the Developer Tools console (Help > Toggle Developer Tools > Console tab) for debug messages with the format:
[Roo-Debug] readApiMessages: ...These logs will show the taskId and file path, helping to diagnose the issue.
Screenshots
N/A - Console logging only
Get in Touch
Discord: KJ7LNW
does not completely fix #4311 but it may provide debug output that may help us fix it from other users.
Important
Adds debug logging to
readApiMessagesfor diagnosing empty or missing API conversation history files.readApiMessagesfor empty API conversation history files.apiConversationHistoryfile is empty.claude_messages.jsonfile is empty.readApiMessagesinapiMessages.tsto include new logging scenarios.This description was created by
for 49a68c1. You can customize this summary. It will automatically update as commits are pushed.