Update regexpp and add support for ES2025 duplicate named capturing groups #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
commented
Jun 29, 2024
| @@ -339,7 +339,6 @@ export function followPaths<S>( | |||
| parent.type === "CharacterClassRange" || | |||
| parent.type === "ClassIntersection" || | |||
| parent.type === "ClassSubtraction" || | |||
| parent.type === "ExpressionCharacterClass" || | |||
There was a problem hiding this comment.
I removed this because of a TS error. I think this is due to the type of regexpp being fixed. In fact, ExpressionCharacterClass never appears here.
|
I realized there were still some changes I needed to make. |
|
I think maybe I could have fixed it. |
|
@RunDevelopment Could you please review this when you have time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates regexpp and add support for ES2025 duplicate named capturing groups.
See also ota-meshi/eslint-plugin-regexp#752, and eslint-community/regexpp#195