Update sensor types and Return correct SensorData Enum #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a changelog entry and also mark it as a breaking change in there, adding variants to an enum (SensorType in this case) can break existing code. |
|
The failing CI check should be gone if you rebase the commits here, this has been fixed recently. |
acieslewicz
force-pushed
the
update_sensor_types
branch
from
5904d1d to
0292397
Compare
|
Rebased and added changelog entries. |
antonilol
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change updates get_data for Gyroscope to return the proper SensorData::Gyro instead of Accel. I think this matches the intended behavior, if not I can undo this. This might change might need to be added to the change log. Let me know if that is the case.
Second change updates SensorTypes to account for new SDL bindings that were added for joycons. This change should address issue #1428.