remove impl ToColor for isize
#1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there is an impl for `u32` already, that impl is now the only one so rustc easily figures out the number type, that does not have to be explicitly annotated anymore. - `isize` is not always wide enough to represent all colors. writing 0xff0000ffisize compiles on 64 bit systems but not on 32 or 16 bit systems. (deny-by-default warning, if `allow`ed it will panic at runtime)
jagprog5
approved these changes
Mar 27, 2025
|
Also included the changelog entry for #1470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
u32already, that impl is now the only one so rustc easily figures out the number type, that does not have to be explicitly annotated anymore.isizeis not always wide enough to represent all colors. writing 0xff0000ffisize compiles on 64 bit systems but not on 32 or 16 bit systems. (deny-by-default warning, ifallowed it will panic at runtime)