Fix usage of isize + reverted some changes for Mouse #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing MouseButtonDown and MouseButtonUp broke the API while it wasn't useful to do so; since the 'None' in Option represents Unknown MouseButton (and not Non-present ones), it is clearer to have an enum variant called Unknown to make the distinction
|
This all looks good to me, although I don't have access to Windows or a 32 bit machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is here only for the travis run, please ignore
THIS BREAKS THE API, mostly gfx and mixer's.
(isize in enums and in your code are bad, avoid using them !)
If possible I'd like someone with a 32bit architecture, and someone on windows to test this as well. I do think it works on every platform but we can never be too sure.
Closes #283 for good
This change is