Audio safety fixes #789
Merged
Audio safety fixes #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transmuting from a value not in the enum is undefined, plus transmuting is generally not great to do.
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Audio safety fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an assert in
get_callbackand noticed when it failed the program segfaulted, this was due to the userdata here Thinkofname@0ca6469#diff-93048819a6101989491fb36a4efc59cbL639 being freed with uninitialized memory. This seemed like the safest way to fix it but there could be a better way.The AudioStatus change is just something I saw when reading through, the use of transmute seemed a bit funny there and could introduce undefined behaviour in safe code.