rust: kernel: workqueue: deref on an immutable reference #900
Conversation
clippy error: if you would like to reborrow, try removing `&*`: `self` Signed-off-by: Alice Ferrazzi <[email protected]> Reviewed-by: Luca Barbato <[email protected]>
| @@ -391,7 +391,7 @@ impl Work { | |||
| // SAFETY: When the work was queued, a call to `into_raw` was made. We just canceled | |||
| // the work without it having the chance to run, so we need to explicitly destroy this | |||
| // reference (which would have happened in `work_func` if it did run). | |||
| unsafe { Ref::from_raw(&*self) }; | |||
| unsafe { Ref::from_raw(self) }; | |||
There was a problem hiding this comment.
Pre-existing, but I think this is actually wrong. Work is not the thing put in a Ref, but the type containing Work. As such self should be value containing Work. Could you please take a look @wedsonaf?
There was a problem hiding this comment.
You're right, we need to do the same pointer arithmetic we do in work_func below to get to the right ptr.
Nice catch, @bjorn3
Now we don't have the type here anymore, so we either need to make Work generic or just store the offset is some field.
There was a problem hiding this comment.
Another option would be to change the function signature to fn cancel<A: WorkAdapter>(obj: Ref<A::Target>) I think.
There was a problem hiding this comment.
But that would be unsafe. Users could use the wrong adapter.
There was a problem hiding this comment.
oops, sorry, I see now that it's passing the outer object.
clippy error: if you would like to reborrow, try removing
&*:selfSigned-off-by: Alice Ferrazzi [email protected]
Reviewed-by: Luca Barbato [email protected]