This repository was archived by the owner on Feb 13, 2024. It is now read-only.
add origin to cf roles #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [inquirer](https://github.com/magmax/python-inquirer) from 2.10.1 to 3.0.0. - [Release notes](https://github.com/magmax/python-inquirer/releases) - [Commits](magmax/python-inquirer@v2.10.1...v3.0.0) --- updated-dependencies: - dependency-name: inquirer dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lechnerc77
requested review from
rui1610 and
lechnerc77
and removed request for
rui1610
1 task
lechnerc77
approved these changes
Dec 5, 2022
|
@pirnz Thanks for your contributions and closing the gap. PR is merged into dev. will be part of next release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
In some cases, the same user exists in more than one identity provider. A common case could be a user existing in both the default SAP ID service and in an Identity Authentication service.
In those cases,
cf set-org-roleandcf set-space-rolewill not assign the user, as it doesn't know which user to choose from. The error it gives is:According to the
cf set-org-roleandcf set-space-role, you can use the option--origin <idp>to specify the idp of the user.I added the same logic applied to the idp for the btp roles so that it only adds the option if they have set the property idp.
Thanks,
Pedro