This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Support app parameters #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lechnerc77
suggested changes
Dec 4, 2022
| @@ -236,11 +240,6 @@ | |||
| "description": "name of the service instance", | |||
| "title": "name of the service instance" | |||
| }, | |||
| "labels":{ | |||
There was a problem hiding this comment.
The functionality of labels are removed with your commit - there seems to be something wrong with the rebase/merge
libs/btpsa-usecase.json
Outdated
| @@ -226,11 +226,6 @@ | |||
| "description": "name of the service instance", | |||
| "title": "name of the service instance" | |||
| }, | |||
| "labels":{ | |||
There was a problem hiding this comment.
The functionality of labels are removed with your commit - there seems to be something wrong with the rebase/merge
|
Great catch! Don't know what happened. I've just fixed the issue and it should be fine now. Would you mind checking again? |
lechnerc77
approved these changes
Dec 5, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #313 so that required parameters for subscribing to apps are provided in the btpsa-usecase.json library.