Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

remove default assignment all roles for main user #346

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Dec 4, 2022

This PR fixes issue #344 around the default assignment to all roles by the user who is calling the script.

@rui1610 rui1610 requested a review from lechnerc77 December 4, 2022 11:14
@lechnerc77 lechnerc77 added this to the btpsa-v1.2.0 milestone Dec 5, 2022
@lechnerc77 lechnerc77 added the bug Something isn't working label Dec 5, 2022
@lechnerc77 lechnerc77 linked an issue Dec 5, 2022 that may be closed by this pull request
2 tasks
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not delete the lines? Maybe a comment might be helpful like the one executing the use case is only added to the role collections defined in the use case if explicitly added.

@rui1610
Copy link
Contributor Author

rui1610 commented Dec 5, 2022

That makes sense Christian. I've added a comment and removed the commented code lines.

@rui1610 rui1610 requested a review from lechnerc77 December 5, 2022 14:10
@lechnerc77 lechnerc77 merged commit 03e0320 into dev Dec 5, 2022
@lechnerc77 lechnerc77 deleted the issue344-fix branch December 6, 2022 10:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong Role Collection assignment
2 participants