Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Role handling #351

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Role handling #351

merged 1 commit into from
Dec 6, 2022

Conversation

lechnerc77
Copy link
Member

Fixing bugs from role handling - see issue #344

@lechnerc77 lechnerc77 added the bug Something isn't working label Dec 6, 2022
@lechnerc77 lechnerc77 added this to the btpsa-v1.2.0 milestone Dec 6, 2022
@lechnerc77 lechnerc77 self-assigned this Dec 6, 2022
@lechnerc77 lechnerc77 linked an issue Dec 6, 2022 that may be closed by this pull request
2 tasks
@lechnerc77 lechnerc77 requested a review from rui1610 December 6, 2022 11:24
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should still be possible to allow additional sub account administrators. With the change in btp_cli.py this will be restricted to one person. This shouldn't be the case.

@lechnerc77
Copy link
Member Author

It should still be possible to allow additional sub account administrators. With the change in btp_cli.py this will be restricted to one person. This shouldn't be the case.

@rui1610 : You can still assign the additional subaccount admins via the usecase.json like this:

{
    "$schema": "https://raw.githubusercontent.com/SAP-samples/btp-setup-automator/main/libs/btpsa-usecase.json",
    "aboutThisUseCase": {
        "name": "Default use case on how to show how btp-setup-automator works.",
        "description": "This usecase sets up services instances of (free) service plans on SAP BTP.",
        "author": "[email protected]",
        "testStatus": "tested successfully",
        "usageStatus": "READY TO BE USED"
    },
    "assignrolecollections": [
        {
            "name": "Subaccount Administrator",
            "type": "account",
            "level": "sub account",
            "assignedUserGroupsFromParameterFile": [
                "admins",
            ]
        },
        {
            "name": "OrgManager",
            "type": "cloudfoundry",
            "level": "org",
            "assignedUserGroupsFromParameterFile": [
                "owners"
            ]
        }
    ]
}

The parameters.json must contain information like this:

{
  "$schema": "https://raw.githubusercontent.com/SAP-samples/btp-setup-automator/main/libs/btpsa-parameters.json",
  "usecasefile": "usecases/released/default.json",
  "region": "us10",
  "globalaccount": "12334556",
  "myemail": "[email protected]",
  "loginmethod": "sso",
  "subaccountname": "test-roles",
  "myusergroups": [
    {
      "name": "admins",
      "members": [
        "[email protected]",
        "[email protected]"
      ]
    },
    {
      "name": "owners",
      "members": [
        "[email protected]",
        "[email protected]"
      ]
    }
  ]
}

@lechnerc77 lechnerc77 merged commit 7091072 into dev Dec 6, 2022
@lechnerc77 lechnerc77 deleted the issue-344 branch December 6, 2022 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong Role Collection assignment
2 participants