Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Fix for Issue 398 #399

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Fix for Issue 398 #399

merged 2 commits into from
Jan 13, 2023

Conversation

lechnerc77
Copy link
Member

@lechnerc77 lechnerc77 commented Jan 13, 2023

Purpose

This PR makes the establishment of trust between XSUAA and an IdP more flexible. The current implementation enforces the establishment of trust between XSUAA and an IdP whenever a service instance of the XSUAA service with the plan apiaccess is created. Although this is the most comfortable way to setup the service with this plan, there are sceanrios where this is not a desired setups (see discussion Skip "SETTING UP TRUST" step)

This PR introduces a new parameter in the usecase.json namely "skipTrustSetupForXSUAA" which allows the caller to define if the setup should be stablished or not. To stay backwards compatible the default value is false.

This parameter is only relevant for the service-plan combination XSUAA - apiaccess

The code is adjusted to consider this new option when setting up the trust.

Does the PR solve an issue

[X] Yes - #398 
[ ] No

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Execute the setup of an XSUAA service with the plan apiaccess:
 "name": "xsuaa",
            "plan": "apiaccess",
            "instancename": "idm_arm",
            "category": "SERVICE",
            "createServiceKeys": [
		        "idm_arm"
		      ]

What to Check

Verify that the following are valid

  • If the parameter "skipTrustSetupForXSUAA" is set to true no trust flow for connecting to an IdP is executed, if set to false or omitted in the usecase.json file the trust flow is executed.

Other Information

n.a.

@lechnerc77 lechnerc77 added the enhancement New feature or request label Jan 13, 2023
@lechnerc77 lechnerc77 added this to the to be planned milestone Jan 13, 2023
@lechnerc77 lechnerc77 self-assigned this Jan 13, 2023
@lechnerc77
Copy link
Member Author

@lechnerc77 lechnerc77 merged commit 1e97fab into dev Jan 13, 2023
@lechnerc77 lechnerc77 deleted the issue-398 branch January 13, 2023 08:34
@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.3.0 Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant