This repository was archived by the owner on Feb 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR makes the establishment of trust between XSUAA and an IdP more flexible. The current implementation enforces the establishment of trust between XSUAA and an IdP whenever a service instance of the XSUAA service with the plan
apiaccess
is created. Although this is the most comfortable way to setup the service with this plan, there are sceanrios where this is not a desired setups (see discussion Skip "SETTING UP TRUST" step)This PR introduces a new parameter in the
usecase.json
namely"skipTrustSetupForXSUAA"
which allows the caller to define if the setup should be stablished or not. To stay backwards compatible the default value isfalse
.The code is adjusted to consider this new option when setting up the trust.
Does the PR solve an issue
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
apiaccess
:What to Check
Verify that the following are valid
"skipTrustSetupForXSUAA"
is set totrue
no trust flow for connecting to an IdP is executed, if set tofalse
or omitted in theusecase.json
file the trust flow is executed.Other Information
n.a.