Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Add provisioning method #433

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Add provisioning method #433

merged 3 commits into from
Feb 20, 2023

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Feb 20, 2023

Purpose

This PR includes the handling of services not requiring the creation of a service instance ("provisioningMethod": "NONE_REQUIRED").

In addition this PR adds a --force-delete capability to prune a sub account, as the recent changes in the BTP have made this necessary (sub account can't be deleted with existing environment instances).

Does the PR solve an issue

[x] Yes - [see issue for "plan not found"](https://github.com/SAP-samples/btp-setup-automator/issues/432)
[ ] No

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Enabling a service that has the provisioningMethod set to "NONE_REQUIRED", should not initiate the creation of a service instance.

Other Information

@cla-assistant
Copy link

cla-assistant bot commented Feb 20, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Feb 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ rui1610
✅ lechnerc77
❌ [btpsa bot] docu generation


[btpsa bot] docu generation seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rui1610 rui1610 changed the base branch from main to dev February 20, 2023 14:56
@rui1610 rui1610 requested a review from lechnerc77 February 20, 2023 15:00
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77 lechnerc77 merged commit f69ff09 into dev Feb 20, 2023
@lechnerc77 lechnerc77 added the enhancement New feature or request label Feb 20, 2023
@lechnerc77 lechnerc77 added this to the btpsa-v1.5.0 milestone Feb 20, 2023
@lechnerc77 lechnerc77 self-assigned this Feb 20, 2023
@lechnerc77 lechnerc77 mentioned this pull request Feb 21, 2023
@lechnerc77 lechnerc77 deleted the add-provisioningMethod branch February 21, 2023 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants