Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

feat: additional parameter files #456

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

bondfelix
Copy link
Contributor

Purpose

I would like to enable the property serviceparameterfile on sapbtp as well on kymaruntime objects.

E.g. to enable this

{
    "category": "ENVIRONMENT",
    "name": "kymaruntime",
    "instancename": "ccircularity-runtime",
    "plan": "aws",
    "amount": 1,
    "serviceparameterfile": "$BTPSA_PARAMETERS_SERVICE_KYMA"
}

or that

{
    "category": "SERVICE",
    "repeatstatusrequest": 60,
    "repeatstatustimeout": 3600,
    "name": "hana-cloud",
    "plan": "hana",
    "targetenvironment": "sapbtp",
    "instancename": "ccircularity-db",
    "serviceparameterfile": "$BTPSA_PARAMETERS_SERVICE_HANA"
}

Does the PR solve an issue

[ ] Yes - Please add issue number
[X] No

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

See configuration examples above.

What to Check

Verify that the following are valid

  • ...

Other Information

@cla-assistant
Copy link

cla-assistant bot commented Mar 9, 2023

CLA assistant check
All committers have signed the CLA.

@bondfelix bondfelix marked this pull request as ready for review March 9, 2023 17:05
@lechnerc77 lechnerc77 changed the base branch from main to dev March 10, 2023 07:04
@lechnerc77 lechnerc77 added the enhancement New feature or request label Mar 10, 2023
@lechnerc77 lechnerc77 added this to the to be planned milestone Mar 10, 2023
@lechnerc77 lechnerc77 self-requested a review March 10, 2023 07:07
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes required

@lechnerc77
Copy link
Member

Hi @bondfelix ,

thanks a lot for your contribution to the project! Highly appreciated. I have just two small remarks before we can merge your change into the dev branch.

@bondfelix bondfelix requested a review from lechnerc77 March 10, 2023 09:12
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rui1610
Copy link
Contributor

rui1610 commented Mar 10, 2023

LGTM, too. Thanks a lot @bondfelix for your contribution!

@lechnerc77 lechnerc77 merged commit 59e16d5 into SAP-samples:dev Mar 10, 2023
@lechnerc77
Copy link
Member

Available in dev; will be merged to stable/main with next release

@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.6.1 Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants