Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Fix NoneType Error during app subscription #470

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

  • In case no app name can be detected for the commercial app name, this PR implements a fallback to use the commercial app name for the app subscription.

Does the PR solve an issue

[ ] Yes - Please add issue number
[X] No

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Rin the failed test for the app "tnt-onboard-dataenrichment-dcp"

What to Check

Verify that the following are valid

  • Verify that the app is subscribed correctly

Other Information

n/a

@lechnerc77 lechnerc77 added the bug Something isn't working label Mar 21, 2023
@lechnerc77 lechnerc77 added this to the to be planned milestone Mar 21, 2023
@lechnerc77 lechnerc77 self-assigned this Mar 21, 2023
@lechnerc77 lechnerc77 requested a review from rui1610 March 21, 2023 11:12
@lechnerc77 lechnerc77 merged commit 3e1039f into dev Mar 23, 2023
@lechnerc77 lechnerc77 deleted the fix-nontype-appsub branch March 23, 2023 07:24
@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.7.0 Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants