refactor(base): Merge styles and utils into base (#38)

BREAKING CHANGE `@ui5-webcomponents-react/styles` and `@ui5-webcomponents-react/utils` are replaced by ``@ui5-webcomponents-react/base`
BREAKING CHANGE Deleted Themes `sap_belize`, `sap_belize_plus` and `sap_belize_hcb`
BREAKING CHANGE Removed `createThemeMap` from base
BREAKING CHANGE Removed `getThemeClassFor` from base
BREAKING CHANGE Removed `getThemeOverwrite` from base
BREAKING CHANGE Deleted `Themes` from base

Closes #34

Author: MarcusNotheis

.gitignore

@@ -5,14 +5,11 @@ yarn-error.log
 .idea
 coverage
 /.env
-lib/
 dist/
 @types
 typings
 !/typings
 .cache
-!packages/utils/src/Device/lib
-!packages/fiori3/src/lib
 build
 /packages/*/npm/**/*.d.ts
 .out

README.md

@@ -27,14 +27,14 @@
     "@babel/plugin-syntax-dynamic-import": "^7.2.0",
     "@babel/preset-env": "^7.4.4",
     "@babel/preset-react": "^7.0.0",
-    "@storybook/addon-actions": "^5.0.11",
-    "@storybook/addon-info": "^5.0.11",
-    "@storybook/addon-knobs": "^5.0.11",
-    "@storybook/addon-options": "^5.0.11",
-    "@storybook/addons": "^5.0.11",
-    "@storybook/react": "^5.0.11",
+    "@storybook/addon-actions": "^5.1.9",
+    "@storybook/addon-info": "^5.1.9",
+    "@storybook/addon-knobs": "^5.1.9",
+    "@storybook/addon-options": "^5.1.9",
+    "@storybook/addons": "^5.1.9",
+    "@storybook/react": "^5.1.9",
     "@storybook/storybook-deployer": "^2.8.1",
-    "@storybook/theming": "^5.0.11",
+    "@storybook/theming": "^5.1.9",
     "@types/chai": "^4.1.7",
     "@types/enzyme": "^3.9.3",
     "@types/hoist-non-react-statics": "^3.3.1",
@@ -85,7 +85,6 @@
     "karma-mocha": "^1.3.0",
     "karma-mocha-reporter": "^2.2.5",
     "karma-mocha-snapshot": "^0.2.1",
-    "karma-selenium-grid-launcher": "^0.2.0",
     "karma-snapshot": "^0.6.0",
     "karma-sourcemap-loader": "^0.3.7",
     "karma-webpack": "^3.0.5",

package.json

@@ -0,0 +1,7 @@
+'use strict';
+
+if (process.env.NODE_ENV === 'production') {
+  module.exports = require('./cjs/base.production.min.js');
+} else {
+  module.exports = require('./cjs/base.development.js');
+}

packages/utils/README.md renamed to packages/base/README.md

@@ -0,0 +1,7 @@
+'use strict';
+
+if (process.env.NODE_ENV === 'production') {
+  module.exports = require('./esm/base.production.min.js');
+} else {
+  module.exports = require('./esm/base.development.js');
+}

packages/styles/index.ts renamed to packages/base/index.ts

@@ -1,20 +1,18 @@
 {
-  "name": "@ui5-webcomponents-react/styles",
+  "name": "@ui5-webcomponents-react/base",
   "version": "0.3.2-rc.2",
-  "description": "Stylesheets for ui5-webcomponents-react",
+  "description": "Base for ui5-webcomponents-react",
   "main": "index.cjs.js",
   "module": "index.esm.js",
   "types": "index.d.ts",
-  "repository": "https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/styles",
+  "repository": "https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/base",
   "author": "SAP SE (https://www.sap.com)",
   "license": "Apache-2.0",
   "dependencies": {
-    "core-js": "^3.1.3",
+    "core-js": "^3.1.4",
+    "tslib": "^1.9.3",
     "deepmerge": "^3.2.0",
     "hoist-non-react-statics": "^3.3.0",
     "react-jss": "^8.6.1"
-  },
-  "peerDependencies": {
-    "react": "^16.8.0"
   }
 }

packages/base/npm/index.cjs.js

@@ -0,0 +1,19 @@
+import { HSLColor } from './HSLColor';
+import { sapColorSemanticNegative, sapUiBrand, sapUiHighlight } from './sap_fiori_3';
+
+describe('HSL Color', () => {
+  test('lighten', () => {
+    const color = HSLColor.of(sapUiHighlight).lighten(63).hsl;
+    expect(color).toEqual('hsl(209.8, 90.9%, 95%)'); //hsl(208.4, 90.5%, 95.9%)
+  });
+
+  test('darken', () => {
+    const color = HSLColor.of(sapUiBrand).darken(10).hsl;
+    expect(color).toEqual('hsl(209.8, 90.9%, 32.9%)'); //hsl(210, 90.5%, 32.9%)
+  });
+
+  test('border bg colors', () => {
+    const color = HSLColor.of(sapColorSemanticNegative).lighten(59.5).hsl;
+    expect(color).toEqual('hsl(0, 100%, 95.5%)'); //hsl(0, 100%, 96.1%)
+  });
+});

packages/base/npm/index.esm.js

@@ -39,9 +39,7 @@ class DeviceLogger {
       component: sComponent || ''
     };
     if (window.console) {
-      const logText = `${oLogEntry.date} ${oLogEntry.time} ${this.sWindowName}${oLogEntry.message} - ${
-        oLogEntry.component
-      }`;
+      const logText = `${oLogEntry.date} ${oLogEntry.time} ${this.sWindowName}${oLogEntry.message} - ${oLogEntry.component}`;
       switch (iLevel) {
         case LOG_LEVEL.FATAL:
         case LOG_LEVEL.ERROR:

packages/styles/package.json renamed to packages/base/package.json

@@ -1,39 +1,3 @@
-import Themes from './Themes';
-
-type ThemeMap = { [theme in Themes]: object };
-
-export const getThemeClassFor = (theme: Themes, themes: ThemeMap) => {
-  if ({}.hasOwnProperty.call(themes, theme)) {
-    return themes[theme];
-  }
-  throw new Error('Could not match theme to Theme Class!');
-};
-
-/**
- * Create a Theme Map for given styles
- * @param light {object} Belize Theme CSS Module
- * @param dark {object} Belize Deep Theme CSS Module
- * @param hcb {object} High Contrast Black Theme CSS Module
- * @return {ThemeMap} Theme Map
- */
-export const createThemeMap = (light: object, dark: object, hcb: object = {}): ThemeMap => ({
-  [Themes.sap_belize]: light,
-  [Themes.sap_belize_plus]: dark,
-  [Themes.sap_belize_hcb]: hcb
-});
-
-/**
- * Get overwrite theme class
- * @param {string} theme
- * @param {string} overwrite
- * @return {string} Theme String
- *
- */
-export const getThemeOverwrite = (theme: Themes, overwrite: Themes): Themes => {
-  if ((Object as any).values(Themes).includes(overwrite)) return overwrite;
-  return theme;
-};
-
 export const deprecationNotice = (component: string, message: string) => {
   const value = `* ui5-webcomponents-react Deprecation Notice - ${component}`;
   const dots = '*'.padStart(value.length, '*');

packages/styles/src/72.ts renamed to packages/base/src/72.ts

@@ -1,36 +1,39 @@
 /**
  * Created by d059190 at 16.03.18
  */
+import font72 from './72';
+import { bootstrap } from './bootstrap';
+import * as fonts from './fonts';
+import { HSLColor } from './HSLColor';
+import * as sap_fiori_3 from './sap_fiori_3';
+import * as spacing from './spacing';
+import { withStyles } from './withStyles';
+import { Device } from './Device';
 import { Event } from './Event';
+import { isNumeric } from './isNumeric';
 import KeyCodes from './KeyCodes';
 import { LOG_LEVEL, Logger } from './Logger';
 import Optional from './Optional';
 import StyleClassHelper from './StyleClassHelper';
-import Themes from './Themes';
-import { isNumeric } from './isNumeric';
-import { Device } from './Device';
 
-import {
-  createThemeMap,
-  deprecationNotice,
-  getThemeClassFor,
-  getThemeOverwrite,
-  pushElementBackInScreen
-} from './Util';
+import { deprecationNotice, pushElementBackInScreen } from './Util';
 
 export {
   StyleClassHelper,
   KeyCodes,
   Optional,
-  getThemeClassFor,
-  createThemeMap,
-  getThemeOverwrite,
   deprecationNotice,
   pushElementBackInScreen,
-  Themes,
   Event,
   Logger,
   LOG_LEVEL,
   isNumeric,
-  Device
+  Device,
+  fonts,
+  font72,
+  spacing,
+  HSLColor,
+  sap_fiori_3,
+  bootstrap,
+  withStyles
 };

packages/utils/src/Device/Browser.test.ts renamed to packages/base/src/Device/Browser.test.ts

@@ -13,8 +13,7 @@
     "@types/chart.js": "^2.7.53"
   },
   "dependencies": {
-    "@ui5-webcomponents-react/styles": "0.3.2-rc.2",
-    "@ui5-webcomponents-react/utils": "0.3.2-rc.2",
+    "@ui5-webcomponents-react/base": "0.3.2-rc.2",
     "chart.js": "^2.8.0",
     "chartjs-plugin-datalabels": "^0.6.0",
     "is-mergeable-object": "^1.1.0",

packages/utils/src/Device/Browser.ts renamed to packages/base/src/Device/Browser.ts

@@ -6,7 +6,7 @@ import { DEFAULT_OPTIONS } from '../../config';
 import { formatTooltipLabel, getTextWidth, mergeConfig } from '../../util/utils';
 import { ChartBaseProps } from '../../interfaces/ChartBaseProps';
 import { ChartBaseDefaultProps } from '../../util/ChartBaseDefaultProps';
-import { LOG_LEVEL, Logger } from '@ui5-webcomponents-react/utils';
+import { LOG_LEVEL, Logger } from '@ui5-webcomponents-react/base';
 import { withChartContainer } from '../ChartContainer/withChartContainer';
 import { BarChartPlaceholder } from './Placeholder';
 

packages/utils/src/Device/EventRegistry.test.ts renamed to packages/base/src/Device/EventRegistry.test.ts

@@ -1,5 +1,5 @@
 import React, { ComponentType } from 'react';
-import { withStyles } from '@ui5-webcomponents-react/styles';
+import { withStyles } from '@ui5-webcomponents-react/base';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 import { DEFAULT_OPTIONS } from '../../config';
 import { ChartBaseProps } from '../../interfaces/ChartBaseProps';

packages/utils/src/Device/EventRegistry.ts renamed to packages/base/src/Device/EventRegistry.ts

@@ -1,4 +1,4 @@
-import { withStyles } from '@ui5-webcomponents-react/styles';
+import { withStyles } from '@ui5-webcomponents-react/base';
 import * as React from 'react';
 import { LoaderStyles } from './Loader.jss';
 

packages/utils/src/Device/Media.test.ts renamed to packages/base/src/Device/Media.test.ts

@@ -1,4 +1,4 @@
-import { withStyles } from '@ui5-webcomponents-react/styles';
+import { withStyles } from '@ui5-webcomponents-react/base';
 import React, { CSSProperties, PureComponent } from 'react';
 import { ChartInternalProps } from '../../interfaces/ChartInternalProps';
 import { CommonProps } from '../../interfaces/CommonProps';

packages/utils/src/Device/Media.ts renamed to packages/base/src/Device/Media.ts

@@ -5,7 +5,7 @@ import { ChartInternalProps } from '../../interfaces/ChartInternalProps';
 import { formatTooltipLabel, mergeConfig } from '../../util/utils';
 import { ChartBaseProps } from '../../interfaces/ChartBaseProps';
 import { ChartBaseDefaultProps } from '../../util/ChartBaseDefaultProps';
-import { HSLColor } from '@ui5-webcomponents-react/styles';
+import { HSLColor } from '@ui5-webcomponents-react/base';
 import { withChartContainer } from '../ChartContainer/withChartContainer';
 
 export interface RadarChartPropTypes extends ChartBaseProps {}

packages/utils/src/Device/OS.test.ts renamed to packages/base/src/Device/OS.test.ts

@@ -1,5 +1,4 @@
-import { StyleClassHelper } from '@ui5-webcomponents-react/utils';
-import { withStyles } from '@ui5-webcomponents-react/styles';
+import { StyleClassHelper, withStyles } from '@ui5-webcomponents-react/base';
 import { ChartOptions } from 'chart.js';
 import React, { CSSProperties, PureComponent, Ref } from 'react';
 import { ChartInternalProps } from '../../interfaces/ChartInternalProps';

packages/utils/src/Device/OS.ts renamed to packages/base/src/Device/OS.ts

@@ -39,7 +39,7 @@ const jsxSpinner = ora('Creating index.tsx').start();
 // create jsx
 const jsxContent = `
 import React, { Component, ComponentClass } from 'react';
-import { withStyles } from '@ui5-webcomponents-react/utils';
+import { withStyles } from '@ui5-webcomponents-react/base';
 import styles from './${componentName}.jss';
 import { ClassProps } from '../../types/ClassProps';
 

packages/utils/src/Device/Orientation.test.ts renamed to packages/base/src/Device/Orientation.test.ts

@@ -59,8 +59,7 @@ SKIP_DOC_GENERATION=true
         '@shared': path.join(PATHS.root, 'shared'),
         '@ui5-webcomponents-react/fiori3': path.join(PATHS.root, 'packages', 'fiori3', 'src', 'index.ts'),
         '@ui5-webcomponents-react/charts': path.join(PATHS.root, 'packages', 'charts', 'src', 'index.ts'),
-        '@ui5-webcomponents-react/utils': path.join(PATHS.root, 'packages', 'utils', 'src', 'index.ts'),
-        '@ui5-webcomponents-react/styles': path.join(PATHS.root, 'packages', 'styles', 'src', 'index.ts')
+        '@ui5-webcomponents-react/base': path.join(PATHS.root, 'packages', 'base', 'src', 'index.ts')
       }
     }
   };

packages/utils/src/Device/Orientation.ts renamed to packages/base/src/Device/Orientation.ts

@@ -16,10 +16,8 @@
     "test:karma:update": "cross-env UPDATE=1 yarn run test:karma"
   },
   "dependencies": {
-    "@ui5-webcomponents-react/styles": "0.3.2-rc.2",
-    "@ui5-webcomponents-react/utils": "0.3.2-rc.2",
+    "@ui5-webcomponents-react/base": "0.3.2-rc.2",
     "@ui5/webcomponents": "0.12.0",
-    "core-js": "^2.6.4",
     "react-scroll": "^1.7.11",
     "react-toastify": "^5.0.1"
   },

packages/utils/src/Device/Resize.test.ts renamed to packages/base/src/Device/Resize.test.ts

@@ -214,7 +214,7 @@ export function generateTypings(meta) {
     .forEach(([key]) => {
       typings[mapEventName(key)] = {
         tsType: '(event : Event) => void',
-        importStatement: "import { Event } from '@ui5-webcomponents-react/utils';"
+        importStatement: "import { Event } from '@ui5-webcomponents-react/base';"
       };
     });
 

packages/utils/src/Device/Resize.ts renamed to packages/base/src/Device/Resize.ts

@@ -40,9 +40,7 @@ async function generateWebComponentWrapper(dto) {
     '\n\n',
     tsTypings.interfaceStatement,
     '\n\n',
-    `const ${componentName}: FC<${tsTypings.interfaceName}> = withWebComponent<${
-      tsTypings.interfaceName
-    }>(${ui5ComponentName});`,
+    `const ${componentName}: FC<${tsTypings.interfaceName}> = withWebComponent<${tsTypings.interfaceName}>(${ui5ComponentName});`,
     '\n\n',
     `${componentName}.displayName = '${componentName}';`,
     '\n\n',

packages/utils/src/Device/Support.ts renamed to packages/base/src/Device/Support.ts

@@ -1,6 +1,6 @@
 <!DOCTYPE html>
 <html>
-    <body>
-        <script src="dist/build.js"></script>
-    </body>
+<body>
+<script src="dist/build.js"></script>
+</body>
 </html>

packages/utils/src/Device/System.test.ts renamed to packages/base/src/Device/System.test.ts

@@ -1,4 +1,5 @@
 import { generateTypings } from './generateTypingsWeb';
+
 const modules = require('./json/modules');
 
 modules.forEach((moduleName) => {

packages/utils/src/Device/System.ts renamed to packages/base/src/Device/System.ts

@@ -1,4 +1,5 @@
 import { generateDiff } from './diff';
+
 const inquirer = require('inquirer');
 const fs = require('fs');
 const chalk = require('chalk');