Skip to content

Merge styles and utils #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 of 5 tasks
MarcusNotheis opened this issue Jun 17, 2019 · 0 comments · Fixed by #38
Closed
4 of 5 tasks

Merge styles and utils #34

MarcusNotheis opened this issue Jun 17, 2019 · 0 comments · Fixed by #38
Assignees
@MarcusNotheis

Comments

@MarcusNotheis
Copy link
Contributor

MarcusNotheis commented Jun 17, 2019 •
edited
Loading

The styles and the utils package are requiring each other, so we duplicate code inside at the moment. Moving forward we want to use the styles from the ui5-webcomponents, so there is no need to keep those packages separate.
--> Merge the styles and the utils package into a new package base.

ToDos:

  • Move Packages into new package base
  • Adjust Readme
  • Adjust npm release scripts
  • Deprecate styles and utils on npm
  • Delete old styles sap_belize, sap_belize_plus and sap_belize_hcb
@MarcusNotheis MarcusNotheis self-assigned this Jun 22, 2019
@MarcusNotheis MarcusNotheis mentioned this issue Jun 24, 2019
Merged
MarcusNotheis added a commit that referenced this issue Jun 24, 2019
@MarcusNotheis
refactor(base): Merge styles and utils into base (#38)
9309505 
BREAKING CHANGE `@ui5-webcomponents-react/styles` and `@ui5-webcomponents-react/utils` are replaced by ``@ui5-webcomponents-react/base`
BREAKING CHANGE Deleted Themes `sap_belize`, `sap_belize_plus` and `sap_belize_hcb`
BREAKING CHANGE Removed `createThemeMap` from base
BREAKING CHANGE Removed `getThemeClassFor` from base
BREAKING CHANGE Removed `getThemeOverwrite` from base
BREAKING CHANGE Deleted `Themes` from base

Closes #34
MarcusNotheis pushed a commit that referenced this issue Oct 21, 2020
@LuisValgoi @MarcusNotheis
Merge pull request #34 from LuisValgoi/issue-20
5fa9be6 
[ISSUE-20-Partial]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcusNotheis MarcusNotheis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge styles and utils into base SAP/ui5-webcomponents-react
1 participant
@MarcusNotheis