Skip to content

AnalyticalTable: wrong table height with renderRowSubComponent true and TableVisibleRowCountMode.Auto #3862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sdommel opened this issue Dec 12, 2022 · 1 comment · Fixed by #4986
Labels

Comments

@sdommel
Copy link

sdommel commented Dec 12, 2022

Describe the bug
When using renderRowSubComponent in AnalyticalTable the sub-row height is somehow not taken into account when rendering the table. Even if visibleRowCountMode is set to Auto, not all rows and sub-rows are displayed, but some are hidden and need scrolling.

Isolated Example
Please provide an isolated example if possible by forking this codesandbox.
https://codesandbox.io/s/sharp-fog-5vj47w?file=/src/App.js

To Reproduce
Steps to reproduce the behavior:
Open example

Expected behavior
All rows and sub-rows are shown and the table has the correct height.

Screenshots

UI5 Web Components for React Information
@ui5/webcomponents version: 1.9.1.
@ui5/webcomponents-react version: 1.6.0
Operating System: Windows
Browser: Chrome

Additional context

@sdommel sdommel added the bug label Dec 12, 2022
Lukas742 added a commit that referenced this issue Aug 30, 2023
This PR adds the `subComponentsBehavior` prop which accepts the
`AnalyticalTableSelectionBehavior` enum.

It enables controlling how subcomponents should be rendered and if they
should be considered when calculating the initial table body height.

`alwaysShowSubComponent` has been deprecated in favor of
`subComponentsBehavior`.

Fixes #3862

---------

Co-authored-by: Marcus Notheis <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🎉 This issue has been resolved in version v1.19.0 🎉

The release is available on v1.19.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant