Skip to content

FormItem: CSS for .FormItem-lastGroupItem does not align with the label #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
C3ntraX opened this issue Jul 27, 2023 · 2 comments · Fixed by #4932
Closed
1 task done

FormItem: CSS for .FormItem-lastGroupItem does not align with the label #4921

C3ntraX opened this issue Jul 27, 2023 · 2 comments · Fixed by #4932
Labels

Comments

@C3ntraX
Copy link

C3ntraX commented Jul 27, 2023

Describe the bug

I don't understand why the last item within a formgroup should have additional margin at the button, because this does not align with a label next to it

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

image

image

image

UI5 Web Components for React Version

1.17.1

UI5 Web Components Version

1.15.1"

Browser

Chrome

Operating System

Windows

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Aug 1, 2023

Hi @C3ntraX

thanks for reporting!
According to the specs, there should be a margin of 1rem at the beginning and at the end of a group. We forgot to apply this for custom label components (instead of plain text), that's why the label is misaligned. The linked PR will fix this.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

🎉 This issue has been resolved in version v1.18.0 🎉

The release is available on v1.18.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants