Skip to content

[DynamicPage]: Incorrect Padding value for the Page Title #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
sfsf-xweb-sh opened this issue Aug 28, 2023 · 1 comment · Fixed by #5020
Closed
1 task done

[DynamicPage]: Incorrect Padding value for the Page Title #5019

sfsf-xweb-sh opened this issue Aug 28, 2023 · 1 comment · Fixed by #5020
Labels

Comments

@sfsf-xweb-sh
Copy link

sfsf-xweb-sh commented Aug 28, 2023

Describe the bug

hi, team

Please help double check the specification for the Page Title (A2).

  1. For the desktop specification applies to Layout sizes L, XL and XXL (padding: 0.3125rem 0 0 0;)
  2. For M Layout Size (Tablet) Specification (padding: 0.6875rem 0 0 0;)

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/story/layouts-floorplans-dynamicpage--default&globals=outline:!true

Reproduction steps

  1. open the https://sap.github.io/ui5-webcomponents-react/?path=/story/layouts-floorplans-dynamicpage--default&globals=outline:!true
  2. check the page title padding-top style
  3. we can see the padding the value of data-component-name="DynamicPageTitleHeader" is 0.3125rem

Expected Behaviour

  1. For the desktop specification applies to Layout sizes L, XL and XXL (padding: 0.3125rem 0 0 0;)
  2. For M Layout Size (Tablet) Specification (padding: 0.6875rem 0 0 0;)

Screenshots or Videos

image

image

UI5 Web Components for React Version

1.17.3

UI5 Web Components Version

1.15.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

🎉 This issue has been resolved in version v1.19.0 🎉

The release is available on v1.19.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant