Skip to content

[MessageView/MessageItem]: MessageItem is using the same container and scrollbar state of MessageView #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
ThiagoSzz opened this issue Dec 14, 2023 · 1 comment · Fixed by #5355
Closed
1 task done
Labels

Comments

@ThiagoSzz
Copy link

ThiagoSzz commented Dec 14, 2023

Describe the bug

When navigating to an item inside the MessageView component, the MessageItem is keeping the same container and scrollbar state of the MessageView.

One side effect of this is that when you have a MessageView with a significant amount of items, when navigating to a MessageItem, the size of the MessageItem container is kept the same as the MessageView. Another side effect is that if you scroll in the MessageView's list, the scrollbar state is kept when navigating to the MessageItem.

Isolated Example

https://sap.github.io/ui5-webcomponents-react/iframe.html?args=&id=user-feedback-messageview--with-message-view-button&viewMode=story

Reproduction steps

  1. Go to https://sap.github.io/ui5-webcomponents-react/iframe.html?args=&id=user-feedback-messageview--with-message-view-button&viewMode=story or find the MessageView component under the User Feedback group and select the with MessageViewButton & Popover option.
image
  1. With the component loaded, click the MessageViewButton.
image
  1. With the Popover opened, scroll down to the last item in the list and select the last item in the list, making the MessageItem view appear.
image
  1. You can notice that the container from the previous tab (MessageView) is used by the MessageItem (use Inspect tool), and the scrollbar state is kept, making the user scroll to the top to see the content of the MessageItem.
image

Expected Behaviour

From my understanding, the MessageItem container should not inherit the width and height of the MessageView container.

Screenshots or Videos

No response

UI5 Web Components for React Version

^1.17.1

UI5 Web Components Version

^1.15.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.23.2 🎉

The release is available on v1.23.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants