Skip to content

[DynamicPage]: pin/collapse toggle buttons incorrectly positioned #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
ee92 opened this issue Jul 9, 2024 · 2 comments · Fixed by #6057
Closed
1 task done

[DynamicPage]: pin/collapse toggle buttons incorrectly positioned #6051

ee92 opened this issue Jul 9, 2024 · 2 comments · Fixed by #6057
Labels

Comments

@ee92
Copy link

ee92 commented Jul 9, 2024

Describe the bug

The toggle buttons are positioned on top of each other, and not centered vertically.

Seems to be due to a css variable scoping issue (works if you change "v1-24-5" to "v1-24-6")

--_ui5wcr_anchor-btn-center: calc((var(--_ui5-v1-24-5_button_base_min_width) - var(--sapButton_BorderWidth))/2);

Isolated Example

https://stackblitz.com/edit/github-yrscqc?file=src%2FApp.tsx

Reproduction steps

  1. go to https://stackblitz.com/edit/github-yrscqc?file=src%2FApp.tsx
  2. notice the toggle buttons are incorrectly positioned

Expected Behaviour

expected correct positioning

Screenshots or Videos

image

UI5 Web Components for React Version

1.29.3

UI5 Web Components Version

1.24.4

Browser

Chrome

Operating System

No response

Additional Context

issue occurring after version 1.28.0

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.4 🎉

The release is available on v1.29.4

Your semantic-release bot 📦🚀

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.0.0-rc.0 🎉

The release is available on v2.0.0-rc.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants