Skip to content

[Charts]: The react charts are not accessible. #6446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
amdev138 opened this issue Oct 4, 2024 · 3 comments · Fixed by #6459
Closed
1 task done

[Charts]: The react charts are not accessible. #6446

amdev138 opened this issue Oct 4, 2024 · 3 comments · Fixed by #6459

Comments

@amdev138
Copy link

amdev138 commented Oct 4, 2024

Describe the bug

Hi team,

Internally we are using recharts. Recharts has recently added an accessibilityLayer prop that you can pass to the component to make it keyboard accessible. Please see: recharts-api-accessibility--docs

However, the ui5-wc react wrapper does not currently have a way to pass this prop to the internal rechart component. From what I can tell, ui5-wc-react current version of recharts is 2.12.7 - which this version has the support for accessibilityLayer. We just need a way to allow the consumer to pass this prop.

Thanks,
Allen

Expected Behaviour

Charts should be accessible.

UI5 Web Components for React Version

main

UI5 Web Components Version

main

Browser

Chrome, Edge, Firefox, Safari

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Oct 7, 2024

Hi @amdev138, the linked PR will allow setting the accessibilityLayer prop on all charts via the chartConfig prop. Please note, that we flagged it as "experimental" as it's not supported for all charts and configurations.

@Lukas742 Lukas742 added the SAP SF label Oct 7, 2024
Lukas742 added a commit that referenced this issue Oct 8, 2024
[Recharts documentation](https://recharts.org/en-US/storybook) udner the
"Accessibility" section

Closes #6446
@amdev138
Copy link
Author

amdev138 commented Oct 9, 2024

Hi @amdev138, the linked PR will allow setting the accessibilityLayer prop on all charts via the chartConfig prop. Please note, that we flagged it as "experimental" as it's not supported for all charts and configurations.

That sounds good to me. Thanks for the quick turn around!

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.3.0 🎉

The release is available on v2.3.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2024-Q4
Development

Successfully merging a pull request may close this issue.

3 participants