Skip to content

[FilterBar] [uwcr v2]: ToolbarButtons not rendered when hideToolbar is set to true #6461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
azhu716 opened this issue Oct 8, 2024 · 1 comment · Fixed by #6464
Closed
1 task done
Labels

Comments

@azhu716
Copy link

azhu716 commented Oct 8, 2024

Describe the bug

When upgraded to uwcr v2, the FilterBar behaves differently from v1. In v1, when passing 'hideToolbar' to the FilterBar, the ToolbarButtons will be rendered after the filter items:
image

However in v2, if we pass the same property, the ToolbarButtons are not visible:
image

Isolated Example

No response

Reproduction steps

  1. Open uwcr v2 document: https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-filterbar--docs
  2. Set the hideToolbar to true
  3. The "Adapt Filters" button is not visible.

Expected Behaviour

The "Adapt Filters" button is visible when hideToolbar is set to true.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.2.0

UI5 Web Components Version

2.3.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.3.0 🎉

The release is available on v2.3.0

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants