Skip to content

SelectDialog: SelectDialog in MultiSelect mode is not handling correctly checkbox clicks for select/deselct #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
SvetoslavZ99 opened this issue Jan 23, 2025 · 2 comments · Fixed by #6860
Closed
1 task done

Comments

@SvetoslavZ99
Copy link

Describe the bug

SelectDialog in MultiSelect mode is not working as expected when I click inside of the checkbox of an item.

If I click somewhere else on the item row, it will correctly register it as a selected item, but this is not the case for the checkbox.

Isolated Example

https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/modals-popovers-selectdialog--docs#selectdialog-in-multiselect-mode-with-search

Reproduction steps

  1. See attached video for the reproduction on your own demo in the docs

Expected Behaviour

No response

Screenshots or Videos

Screen.Recording.2025-01-23.at.17.15.09.mov

UI5 Web Components for React Version

2.6.0

UI5 Web Components Version

Not used in our project. See internal dependency to the 2.6.0 of webcomponents-react

Browser

Chrome

Operating System

Mac OS

Additional Context

No response

Relevant log output

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Hi @SvetoslavZ99

our story is incorrect here. It seems like the item-click event behaves differently than it did with v1 of @ui5/webcomponents which wasn't outlined in their migration guide. The linked PR will adjust this.

Also, I've asked the UI5 Web Components team to better outline this behavior to prevent further confusion: SAP/ui5-webcomponents#10183 (comment)

@SvetoslavZ99
Copy link
Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

2 participants