Skip to content

[V1][AnalyticalTable] Throwing error on init #7093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ej612 opened this issue Mar 17, 2025 · 2 comments · Fixed by #7100
Closed

[V1][AnalyticalTable] Throwing error on init #7093

ej612 opened this issue Mar 17, 2025 · 2 comments · Fixed by #7100
Labels
released v1 PR or issue only relevant for v1

Comments

@ej612
Copy link
Contributor

ej612 commented Mar 17, 2025

Describe the bug

Our AnalyticalTable throws an error on init:

Image

The culprit is the return statement in ColumnHeaderContainer.

On the v1.29.x branch, it looks like this:

return (
  <div
    {...headerProps} // <- This is where it crashes
  >

The problem is that headerProps contains a key prop which React doesn't seem to like. On the main branch, the issue is resolved by isolating key and setting it explicitly:

const { key, ...reactTableHeaderProps } = headerProps;

return (
  <div
    key={key}
    {...reactTableHeaderProps}

Could we get a backport of this fix to v1?

Thank you very much in advance!

UI5 Web Components for React Version

1.29.14

UI5 Web Components Version

1.24.13

@Lukas742
Copy link
Contributor

Hi @ej612

this warning was introduced in React v18.3 in preparation for React 19, but as spreading a key was an anti-pattern even before, we'll fix the issue with the linked PR in our v1 as well.

@Lukas742 Lukas742 linked a pull request Mar 19, 2025 that will close this issue
Lukas742 added a commit that referenced this issue Mar 19, 2025
This warning was introduced in React v18.3.

Fixes #7093
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.19 🎉

The release is available on v1.29.19

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released v1 PR or issue only relevant for v1
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants