Skip to content

feat(ObjectPage): Collapse header on scroll #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions demo/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
import React from 'react';
import { render } from 'react-dom';
import { ObjectPage } from '@ui5/webcomponents-react/lib/ObjectPage';
import { Button } from '@ui5/webcomponents-react/lib/Button';
import { ButtonDesign } from '@ui5/webcomponents-react/lib/ButtonDesign';
import { Link } from '@ui5/webcomponents-react/lib/Link';
import { ObjectPageSection } from '@ui5/webcomponents-react/lib/ObjectPageSection';
import { ObjectPageSubSection } from '@ui5/webcomponents-react/lib/ObjectPageSubSection';
import { Text } from '@ui5/webcomponents-react/lib/Text';
import SampleImage from '@ui5/webcomponents-react/src/components/ObjectPage/DemoImage.png';
import { ThemeProvider } from '@ui5/webcomponents-react/lib/ThemeProvider';

const renderHeaderContent = () => (
<div style={{ display: 'flex', flexDirection: 'column' }}>
<Link href="https://www.sap.com">www.myurl.com</Link>
<Text>Address 1</Text>
<Text>Address 2</Text>
<Text>Address 3</Text>
</div>
);

render(
<ThemeProvider>
<ObjectPage
title={'Object Page Title'}
subTitle={'Object Page Sub Title'}
headerActions={[
<Button key="1" design={ButtonDesign.Emphasized}>
Primary Action
</Button>,
<Button key="2">Action</Button>
]}
image={SampleImage}
renderHeaderContent={renderHeaderContent}
imageShapeCircle={false}
showHideHeaderButton={true}
style={{ height: '700px' }}
>
<ObjectPageSection title="Test 1" id="1">
<div style={{ height: '20px' }}>My Content 1</div>
</ObjectPageSection>
<ObjectPageSection title="Test 2" id="2">
<div style={{ height: '800px' }}>Test2</div>
</ObjectPageSection>
<ObjectPageSection title="Test 3" id="3">
Test1
</ObjectPageSection>
<ObjectPageSection title="Test 4" id="4">
<h1>Section 4</h1>
<ObjectPageSubSection title="SubSection 4.1" id="4.1">
Test 4 SubSection 1
</ObjectPageSubSection>
<ObjectPageSubSection title="SubSection 4.2" id="4.2">
Test 4 SubSection 2
</ObjectPageSubSection>
</ObjectPageSection>
<ObjectPageSection title="Test 5" id="5">
<ObjectPageSubSection title="SubSection 5.1" id="5.1">
Content of SubSection 5.1
</ObjectPageSubSection>
<ObjectPageSubSection title="SubSection 5.2" id="5.2">
Content of SubSection 5.2
</ObjectPageSubSection>
</ObjectPageSection>
</ObjectPage>{' '}
</ThemeProvider>,
document.querySelector('body')
);
55 changes: 55 additions & 0 deletions demo/webpack.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
const PATHS = require('../config/paths');
const path = require('path');

const tsLoader = {
test: /\.[tj]sx?$/,
use: [
{
loader: require.resolve('babel-loader'),
options: {
presets: [[require.resolve('babel-preset-react-app'), { flow: false, typescript: true }]]
}
}
]
};

process.env.NODE_ENV = 'development';
process.env.BABEL_ENV = 'development';

const HtmlWebpackPlugin = require('html-webpack-plugin');
module.exports = {
mode: 'development',
entry: './index.js',
module: {
rules: [
tsLoader,
{
test: /\.png$/,
use: 'file-loader'
},
{
test: /\.css$/,
use: ['style-loader', 'css-loader'],
exclude: {
test: [/test-resources/]
}
}
]
},
devServer: {
contentBase: __dirname,
compress: true,
port: 9000
},
output: {
path: __dirname + '/dist',
filename: 'index_bundle.js'
},
plugins: [new HtmlWebpackPlugin()],
resolve: {
extensions: ['.ts', '.tsx', '.js', '.jsx', '.cjs', '.mjs', '.esm'],
alias: {
'@ui5/webcomponents-react/lib': path.join(PATHS.root, 'packages', 'main', 'src', 'lib')
}
}
};
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"global": "^4.4.0",
"google-closure-compiler": "^20190415.0.0",
"gzip-size": "^5.1.0",
"html-webpack-plugin": "^3.2.0",
"husky": "^3.0.2",
"identity-obj-proxy": "^3.0.0",
"istanbul-instrumenter-loader": "^3.0.1",
Expand Down Expand Up @@ -120,7 +121,8 @@
"util": "^0.12.0",
"uuid": "^3.3.2",
"webpack": "^4.39.1",
"webpack-cli": "^3.3.2"
"webpack-cli": "^3.3.2",
"webpack-dev-server": "^3.8.0"
},
"resolutions": {
"@types/react": "16.8.24"
Expand Down
Empty file.
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/CustomListItem.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<CustomListItem type="Active">
<ui5-li-custom type="Active" class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/DayPicker.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<DayPicker>
<ui5-daypicker class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/GroupHeaderListItem.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<GroupHeaderListItem>
<ui5-li-groupheader class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/Input.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<Input placeholder={{...}} type="Text" value="" valueState="None">
<ui5-input placeholder={{...}} type="Text" value="" value-state="None" class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/Link.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<Link design="Default">
<ui5-link design="Default" class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/MessageStrip.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<MessageStrip type="Information">
<ui5-messagestrip type="Information" class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/MonthPicker.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<MonthPicker>
<ui5-month-picker class="" />
Expand Down
4 changes: 2 additions & 2 deletions packages/main/__karma_snapshots__/MultiComboBox.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#### `Basic Test (generated)`

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<ThemeProvider withToastContainer={false} noInjectThemeProperties={false}>
<JssProvider generateId={[Function]} jss={[undefined]}>
<ThemeProvider theme={{...}}>
<MultiComboBox value="" placeholder="" valueState="None">
<ui5-multi-combobox value="" placeholder="" value-state="None" class="" />
Expand Down
Loading