-
Notifications
You must be signed in to change notification settings - Fork 104
feat(Loader): Initial Implementation #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct into feature/Loader
MarcusNotheis
requested changes
Sep 25, 2019
Co-Authored-By: Marcus Notheis <[email protected]>
…ct into feature/Loader
MarcusNotheis
approved these changes
Sep 26, 2019
renovate bot
added a commit
that referenced
this pull request
Oct 23, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@babel/cli](https://babel.dev/docs/en/next/babel-cli) ([source](https://redirect.github.com/babel/babel/tree/HEAD/packages/babel-cli)) | [`7.25.7` -> `7.25.9`](https://renovatebot.com/diffs/npm/@babel%2fcli/7.25.7/7.25.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://redirect.github.com/babel/babel/tree/HEAD/packages/babel-core)) | [`7.25.8` -> `7.25.9`](https://renovatebot.com/diffs/npm/@babel%2fcore/7.25.8/7.25.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@babel/preset-env](https://babel.dev/docs/en/next/babel-preset-env) ([source](https://redirect.github.com/babel/babel/tree/HEAD/packages/babel-preset-env)) | [`7.25.8` -> `7.25.9`](https://renovatebot.com/diffs/npm/@babel%2fpreset-env/7.25.8/7.25.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@babel/preset-react](https://babel.dev/docs/en/next/babel-preset-react) ([source](https://redirect.github.com/babel/babel/tree/HEAD/packages/babel-preset-react)) | [`7.25.7` -> `7.25.9`](https://renovatebot.com/diffs/npm/@babel%2fpreset-react/7.25.7/7.25.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@babel/preset-typescript](https://babel.dev/docs/en/next/babel-preset-typescript) ([source](https://redirect.github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript)) | [`7.25.7` -> `7.25.9`](https://renovatebot.com/diffs/npm/@babel%2fpreset-typescript/7.25.7/7.25.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.16.11` -> `20.16.15`](https://renovatebot.com/diffs/npm/@types%2fnode/20.16.11/20.16.15) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.3.11` -> `18.3.12`](https://renovatebot.com/diffs/npm/@types%2freact/18.3.11/18.3.12) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vitejs/plugin-react](https://redirect.github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#readme) ([source](https://redirect.github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react)) | [`4.3.2` -> `4.3.3`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-react/4.3.2/4.3.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-react](https://redirect.github.com/jsx-eslint/eslint-plugin-react) | [`7.37.1` -> `7.37.2`](https://renovatebot.com/diffs/npm/eslint-plugin-react/7.37.1/7.37.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [eslint-plugin-storybook](https://redirect.github.com/storybookjs/eslint-plugin-storybook) | [`0.10.0--canary.156.ce8985b.0` -> `0.10.1`](https://renovatebot.com/diffs/npm/eslint-plugin-storybook/0.10.0--canary.156.ce8985b.0/0.10.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [npm-run-all2](https://redirect.github.com/bcomnes/npm-run-all2) | [`6.2.3` -> `6.2.6`](https://renovatebot.com/diffs/npm/npm-run-all2/6.2.3/6.2.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [typedoc](https://typedoc.org) ([source](https://redirect.github.com/TypeStrong/TypeDoc)) | [`0.26.9` -> `0.26.10`](https://renovatebot.com/diffs/npm/typedoc/0.26.9/0.26.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [vite](https://vite.dev) ([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.4.8` -> `5.4.10`](https://renovatebot.com/diffs/npm/vite/5.4.8/5.4.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [yarn](https://redirect.github.com/yarnpkg/berry) ([source](https://redirect.github.com/yarnpkg/berry/tree/HEAD/packages/yarnpkg-cli)) | [`4.5.0` -> `4.5.1`](https://renovatebot.com/diffs/npm/yarn/4.5.0/4.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>babel/babel (@​babel/cli)</summary> ### [`v7.25.9`](https://redirect.github.com/babel/babel/blob/HEAD/CHANGELOG.md#v7259-2024-10-22) [Compare Source](https://redirect.github.com/babel/babel/compare/v7.25.7...v7.25.9) ##### 🐛 Bug Fix - `babel-parser`, `babel-template`, `babel-types` - [#​16905](https://redirect.github.com/babel/babel/pull/16905) fix: Keep type annotations in `syntacticPlaceholders` mode ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) - `babel-helper-compilation-targets`, `babel-preset-env` - [#​16907](https://redirect.github.com/babel/babel/pull/16907) fix: support BROWSERSLIST{,\_CONFIG} env ([@​JLHwung](https://redirect.github.com/JLHwung)) - Other - [#​16884](https://redirect.github.com/babel/babel/pull/16884) Analyze `ClassAccessorProperty` to prevent the `no-undef` rule ([@​victorenator](https://redirect.github.com/victorenator)) ##### 🏠 Internal - `babel-helper-transform-fixture-test-runner` - [#​16914](https://redirect.github.com/babel/babel/pull/16914) remove test options flaky ([@​JLHwung](https://redirect.github.com/JLHwung)) ##### 🏃♀️ Performance - `babel-parser`, `babel-types` - [#​16918](https://redirect.github.com/babel/babel/pull/16918) perf: Make `VISITOR_KEYS` etc. faster to access ([@​liuxingbaoyu](https://redirect.github.com/liuxingbaoyu)) </details> <details> <summary>vitejs/vite-plugin-react (@​vitejs/plugin-react)</summary> ### [`v4.3.3`](https://redirect.github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#433-2024-10-19) [Compare Source](https://redirect.github.com/vitejs/vite-plugin-react/compare/v4.3.2...v4.3.3) ##### React Compiler runtimeModule option removed React Compiler was updated to accept a `target` option and `runtimeModule` was removed. vite-plugin-react will still detect `runtimeModule` for backwards compatibility. When using a custom `runtimeModule` or `target !== '19'`, the plugin will not try to pre-optimize `react/compiler-runtime` dependency. The [react-compiler-runtime](https://www.npmjs.com/package/react-compiler-runtime) is now available on npm can be used instead of the local shim for people using the compiler with React < 19. Here is the configuration to use the compiler with React 18 and correct source maps in development: ```bash npm install babel-plugin-react-compiler react-compiler-runtime @​babel/plugin-transform-react-jsx-development ``` ```ts export default defineConfig(({ command }) => { const babelPlugins = [['babel-plugin-react-compiler', { target: '18' }]] if (command === 'serve') { babelPlugins.push(['@​babel/plugin-transform-react-jsx-development', {}]) } return { plugins: [react({ babel: { plugins: babelPlugins } })], } }) ``` </details> <details> <summary>jsx-eslint/eslint-plugin-react (eslint-plugin-react)</summary> ### [`v7.37.2`](https://redirect.github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7372---20241022) [Compare Source](https://redirect.github.com/jsx-eslint/eslint-plugin-react/compare/v7.37.1...v7.37.2) ##### Fixed - \[`destructuring-assignment`]: fix false negative when using `typeof props.a` ([#​3835][] [@​golopot](https://redirect.github.com/golopot)) ##### Changed - \[Refactor] \[`destructuring-assignment`]: use `getParentStatelessComponent` ([#​3835][] [@​golopot](https://redirect.github.com/golopot)) [7.37.2]: https://redirect.github.com/jsx-eslint/eslint-plugin-react/compare/v7.37.1...v7.37.2 [#​3835]: https://redirect.github.com/jsx-eslint/eslint-plugin-react/pull/3835 </details> <details> <summary>storybookjs/eslint-plugin-storybook (eslint-plugin-storybook)</summary> ### [`v0.10.1`](https://redirect.github.com/storybookjs/eslint-plugin-storybook/blob/HEAD/CHANGELOG.md#v0101-Mon-Oct-21-2024) [Compare Source](https://redirect.github.com/storybookjs/eslint-plugin-storybook/compare/v0.10.0...v0.10.1) ##### 🐛 Bug Fix - Bump CSF version to remove lodash transitive dep [#​171](https://redirect.github.com/storybookjs/eslint-plugin-storybook/pull/171) ([@​kasperpeulen](https://redirect.github.com/kasperpeulen)) ##### Authors: 1 - Kasper Peulen ([@​kasperpeulen](https://redirect.github.com/kasperpeulen)) *** ### [`v0.10.0`](https://redirect.github.com/storybookjs/eslint-plugin-storybook/blob/HEAD/CHANGELOG.md#v0100-Mon-Oct-21-2024) [Compare Source](https://redirect.github.com/storybookjs/eslint-plugin-storybook/compare/ce8985b05e5bbacc9d6258d34b4011114808b5be...v0.10.0) ##### 🚀 Enhancement - feat: support flat config [#​156](https://redirect.github.com/storybookjs/eslint-plugin-storybook/pull/156) ([@​kazupon](https://redirect.github.com/kazupon) [@​yannbf](https://redirect.github.com/yannbf) [@​kasperpeulen](https://redirect.github.com/kasperpeulen)) ##### Authors: 3 - Kasper Peulen ([@​kasperpeulen](https://redirect.github.com/kasperpeulen)) - kazuya kawaguchi ([@​kazupon](https://redirect.github.com/kazupon)) - Yann Braga ([@​yannbf](https://redirect.github.com/yannbf)) *** </details> <details> <summary>bcomnes/npm-run-all2 (npm-run-all2)</summary> ### [`v6.2.6`](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.5...67a6356a185f6ca5b4a39d88613c8aa491c648c0) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/ee3bf122e700102b9ab27b1d172d98856765f4a4...v6.2.6) ### [`v6.2.5`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v625) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) ##### Merged - Prevent a throw when looking up undefined results [`#158`](https://redirect.github.com/bcomnes/npm-run-all2/pull/158) ##### Commits - **Breaking change:** Bump node engines ^18.17.0 || >=20.5.0 [`49b95f0`](https://redirect.github.com/bcomnes/npm-run-all2/commit/49b95f0c4905504a94d1a7ce87fbb7e77ab60df5) - Merge pull request [#​156](https://redirect.github.com/bcomnes/npm-run-all2/issues/156) from bcomnes/rm-rf-rimraf [`c661ffc`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c661ffc942e09a68b1a553190d3a550dc0f6a39c) - Remove rimraf [`c77e085`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c77e0856c65115b32788c3e9a1e441ba69fbd430) ### [`v6.2.4`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v624) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.3...v6.2.4) ##### Merged - Switch to JS-based `which` command [`#154`](https://redirect.github.com/bcomnes/npm-run-all2/pull/154) ##### Fixed - Switch to JS-based `which` command [`#153`](https://redirect.github.com/bcomnes/npm-run-all2/issues/153) </details> <details> <summary>TypeStrong/TypeDoc (typedoc)</summary> ### [`v0.26.10`](https://redirect.github.com/TypeStrong/TypeDoc/blob/HEAD/CHANGELOG.md#v02610-2024-10-16) [Compare Source](https://redirect.github.com/TypeStrong/TypeDoc/compare/v0.26.9...v0.26.10) ##### Bug Fixes - Fixed missing space on page headers, [#​2748](https://redirect.github.com/TypeStrong/TypeDoc/issues/2748). </details> <details> <summary>vitejs/vite (vite)</summary> ### [`v5.4.10`](https://redirect.github.com/vitejs/vite/releases/tag/v5.4.10) [Compare Source](https://redirect.github.com/vitejs/vite/compare/v5.4.9...v5.4.10) Please refer to [CHANGELOG.md](https://redirect.github.com/vitejs/vite/blob/v5.4.10/packages/vite/CHANGELOG.md) for details. ### [`v5.4.9`](https://redirect.github.com/vitejs/vite/releases/tag/v5.4.9) [Compare Source](https://redirect.github.com/vitejs/vite/compare/v5.4.8...v5.4.9) Please refer to [CHANGELOG.md](https://redirect.github.com/vitejs/vite/blob/v5.4.9/packages/vite/CHANGELOG.md) for details. </details> <details> <summary>yarnpkg/berry (yarn)</summary> ### [`v4.5.1`](https://redirect.github.com/yarnpkg/berry/compare/68e10d099fb6bee03e4450bc516c0c04e24bcb96...b5baf9bb17ca953fe7faa593090a6376bd3d0156) [Compare Source](https://redirect.github.com/yarnpkg/berry/compare/68e10d099fb6bee03e4450bc516c0c04e24bcb96...b5baf9bb17ca953fe7faa593090a6376bd3d0156) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
that referenced
this pull request
Oct 23, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [npm-run-all2](https://redirect.github.com/bcomnes/npm-run-all2) | [`^6.0.0` -> `^7.0.0`](https://renovatebot.com/diffs/npm/npm-run-all2/6.2.3/7.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bcomnes/npm-run-all2 (npm-run-all2)</summary> ### [`v7.0.0`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v700) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.6...v7.0.0) ##### Merged - Prevent a throw when looking up undefined results [`#158`](https://redirect.github.com/bcomnes/npm-run-all2/pull/158) ##### Commits - **Breaking change:** Bump node engines ^18.17.0 || >=20.5.0 [`49b95f0`](https://redirect.github.com/bcomnes/npm-run-all2/commit/49b95f0c4905504a94d1a7ce87fbb7e77ab60df5) - Merge pull request [#​156](https://redirect.github.com/bcomnes/npm-run-all2/issues/156) from bcomnes/rm-rf-rimraf [`c661ffc`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c661ffc942e09a68b1a553190d3a550dc0f6a39c) - Remove rimraf [`c77e085`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c77e0856c65115b32788c3e9a1e441ba69fbd430) ### [`v6.2.6`](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.5...67a6356a185f6ca5b4a39d88613c8aa491c648c0) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/ee3bf122e700102b9ab27b1d172d98856765f4a4...v6.2.6) ### [`v6.2.5`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v625) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.4...ee3bf122e700102b9ab27b1d172d98856765f4a4) ##### Merged - Prevent a throw when looking up undefined results [`#158`](https://redirect.github.com/bcomnes/npm-run-all2/pull/158) ##### Commits - **Breaking change:** Bump node engines ^18.17.0 || >=20.5.0 [`49b95f0`](https://redirect.github.com/bcomnes/npm-run-all2/commit/49b95f0c4905504a94d1a7ce87fbb7e77ab60df5) - Merge pull request [#​156](https://redirect.github.com/bcomnes/npm-run-all2/issues/156) from bcomnes/rm-rf-rimraf [`c661ffc`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c661ffc942e09a68b1a553190d3a550dc0f6a39c) - Remove rimraf [`c77e085`](https://redirect.github.com/bcomnes/npm-run-all2/commit/c77e0856c65115b32788c3e9a1e441ba69fbd430) ### [`v6.2.4`](https://redirect.github.com/bcomnes/npm-run-all2/blob/HEAD/CHANGELOG.md#v624) [Compare Source](https://redirect.github.com/bcomnes/npm-run-all2/compare/v6.2.3...v6.2.4) ##### Merged - Switch to JS-based `which` command [`#154`](https://redirect.github.com/bcomnes/npm-run-all2/pull/154) ##### Fixed - Switch to JS-based `which` command [`#153`](https://redirect.github.com/bcomnes/npm-run-all2/issues/153) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist