-
Notifications
You must be signed in to change notification settings - Fork 104
Feat/analytical table dnd #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for ui5-webcomponents-react ready! Built with commit e57e690 https://deploy-preview-229--ui5-webcomponents-react.netlify.com |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 71.93% 72.26% +0.33%
==========================================
Files 159 160 +1
Lines 3492 3534 +42
Branches 611 615 +4
==========================================
+ Hits 2512 2554 +42
+ Misses 763 756 -7
- Partials 217 224 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm! Just some minor comments:
- Could you please delete the package-lock.json files as we´re using yarn and its not a good idea to mix those up.
- When I start to drag a column, but don´t drop it in a new position, the visual feedback that the column is being dragged does not disappear
packages/main/src/components/AnalyticalTable/ColumnHeader/index.tsx
Outdated
Show resolved
Hide resolved
packages/main/src/components/AnalyticalTable/hooks/useResizeColumns.ts
Outdated
Show resolved
Hide resolved
packages/main/src/components/AnalyticalTable/hooks/useResizeColumns.ts
Outdated
Show resolved
Hide resolved
…use of a standard style added; custom dnd hook added
… into feat/analytical-table-dnd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we´re almost done!
Just two minor things:
- There is a typo in the
useDragAndDrop
custom hook file name - Could you please add an
onColumnsReordered
event to the Analytical Table, so that someone can react from outside when columns are being reordered? The user should get the columns array in the new order as well as the column that has been moved.
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist