Skip to content

feat(AnalyticalTable): Add prop selectionMode #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2019

Conversation

MarcusNotheis
Copy link
Contributor

Allows different selection modes via TableSelectionMode enum with values NONE, SINGLE_SELECT, MULTI_SELECT
BREAKING CHANGE: Replace prop selectable with selectionMode

Allows different selection modes via `TableSelectionMode` enum with values `NONE`, `SINGLE_SELECT`, `MULTI_SELECT`
BREAKING CHANGE: Replace prop `selectable` with `selectionMode`
@netlify
Copy link

netlify bot commented Dec 20, 2019

Deploy preview for ui5-webcomponents-react ready!

Built with commit f3ccfd4

https://deploy-preview-258--ui5-webcomponents-react.netlify.com

@codecov-io
Copy link

Codecov Report

Merging #258 into master will decrease coverage by 0.03%.
The diff coverage is 53.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   73.52%   73.49%   -0.04%     
==========================================
  Files         160      160              
  Lines        3498     3490       -8     
  Branches      607      607              
==========================================
- Hits         2572     2565       -7     
+ Misses        723      722       -1     
  Partials      203      203
Impacted Files Coverage Δ
...ages/main/src/components/AnalyticalTable/index.tsx 78.57% <ø> (ø) ⬆️
...AnalyticalTable/ColumnHeader/ColumnHeaderModal.tsx 36.66% <ø> (ø) ⬆️
...nts/AnalyticalTable/hooks/useTableHeaderStyling.ts 100% <100%> (ø) ⬆️
...nalyticalTable/hooks/useTableHeaderGroupStyling.ts 100% <100%> (ø) ⬆️
...omponents/AnalyticalTable/hooks/useTableStyling.ts 100% <100%> (ø) ⬆️
...nalyticalTable/virtualization/VirtualTableBody.tsx 84% <100%> (+0.66%) ⬆️
...nents/AnalyticalTable/hooks/useTableCellStyling.ts 37.93% <37.93%> (-2.07%) ⬇️
...onents/AnalyticalTable/hooks/useToggleRowExpand.ts 41.66% <41.66%> (-4.49%) ⬇️
...onents/AnalyticalTable/hooks/useTableRowStyling.ts 45.45% <42.85%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f44a72...f3ccfd4. Read the comment docs.

@MarcusNotheis MarcusNotheis merged commit f322bd0 into master Dec 20, 2019
@MarcusNotheis MarcusNotheis deleted the feat/analytical-table-selection-mode branch December 20, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants