Skip to content

Repository Renaming #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
To get it merged faster, kindly review the checklist below:

## Pull Request Checklist
- [ ] Reviewed the [Contributing Guidelines](https://github.com/SAP/fiori-for-react/blob/master/CONTRIBUTING.md)
+ Especially the [How to Contribute](https://github.com/SAP/fiori-for-react/blob/master/CONTRIBUTING.md#contribute-code) section
- [ ] [Correct commit message style](https://github.com/SAP/fiori-for-react/blob/master/docs/Guidelines.md#commit-message-style)
- [ ] Reviewed the [Contributing Guidelines](https://github.com/SAP/ui5-webcomponents-react/blob/master/CONTRIBUTING.md)
+ Especially the [How to Contribute](https://github.com/SAP/ui5-webcomponents-react/blob/master/CONTRIBUTING.md#contribute-code) section
- [ ] [Correct commit message style](https://github.com/SAP/ui5-webcomponents-react/blob/master/docs/Guidelines.md#commit-message-style)
38 changes: 19 additions & 19 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [0.3.2-rc.0](https://github.com/SAP/fiori-for-react/compare/v0.3.1-rc.2...v0.3.2-rc.0) (2019-06-14)
## [0.3.2-rc.0](https://github.com/SAP/ui5-webcomponents-react/compare/v0.3.1-rc.2...v0.3.2-rc.0) (2019-06-14)


### Features

* **ThemeProvider:** Read config from UI5 Web Components ([efee11f](https://github.com/SAP/fiori-for-react/commit/efee11f))
* **ThemeProvider:** Read config from UI5 Web Components ([efee11f](https://github.com/SAP/ui5-webcomponents-react/commit/efee11f))


### BREAKING CHANGES
Expand All @@ -20,12 +20,12 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline



## [0.3.1-rc.2](https://github.com/SAP/fiori-for-react/compare/v0.3.1-rc.1...v0.3.1-rc.2) (2019-06-13)
## [0.3.1-rc.2](https://github.com/SAP/ui5-webcomponents-react/compare/v0.3.1-rc.1...v0.3.1-rc.2) (2019-06-13)


### Features

* Update UI5 WebComponents to v0.12.0 ([#30](https://github.com/SAP/fiori-for-react/issues/30)) ([4958a15](https://github.com/SAP/fiori-for-react/commit/4958a15))
* Update UI5 WebComponents to v0.12.0 ([#30](https://github.com/SAP/ui5-webcomponents-react/issues/30)) ([4958a15](https://github.com/SAP/ui5-webcomponents-react/commit/4958a15))


### BREAKING CHANGES
Expand All @@ -41,40 +41,40 @@ See also [UI5-WebComponents 0.12.0](https://github.com/SAP/ui5-webcomponents/rel



## [0.3.1-rc.1](https://github.com/SAP/fiori-for-react/compare/v0.3.1-rc.0...v0.3.1-rc.1) (2019-06-07)
## [0.3.1-rc.1](https://github.com/SAP/ui5-webcomponents-react/compare/v0.3.1-rc.0...v0.3.1-rc.1) (2019-06-07)


### Features

* **ObjectPage:** Added Hide Header Button ([#28](https://github.com/SAP/fiori-for-react/issues/28)) ([5509098](https://github.com/SAP/fiori-for-react/commit/5509098))
* **ObjectPage:** Added Hide Header Button ([#28](https://github.com/SAP/ui5-webcomponents-react/issues/28)) ([5509098](https://github.com/SAP/ui5-webcomponents-react/commit/5509098))





## [0.3.1-rc.0](https://github.com/SAP/fiori-for-react/compare/v0.3.0...v0.3.1-rc.0) (2019-06-03)
## [0.3.1-rc.0](https://github.com/SAP/ui5-webcomponents-react/compare/v0.3.0...v0.3.1-rc.0) (2019-06-03)

**Note:** Version bump only for package @fiori-for-react/suite
**Note:** Version bump only for package @ui5-webcomponents-react/suite





# [0.3.0](https://github.com/SAP/fiori-for-react/compare/v0.2.0...v0.3.0) (2019-06-03)
# [0.3.0](https://github.com/SAP/ui5-webcomponents-react/compare/v0.2.0...v0.3.0) (2019-06-03)

### Features

* Updated UI5 WebComponents to v0.11.0 ([#22](https://github.com/SAP/fiori-for-react/issues/22)) ([7dcf22b](https://github.com/SAP/fiori-for-react/commit/7dcf22b))
* **FilterBar:** Initial Version ([422bdbd](https://github.com/SAP/fiori-for-react/commit/422bdbd))
* **FilterItem:** Initial Version ([19a23ec](https://github.com/SAP/fiori-for-react/commit/19a23ec))
* **VariantManagement:** Initial Version ([a1e9cbb](https://github.com/SAP/fiori-for-react/commit/a1e9cbb))
* **FilterBar:** renderSearch function ([94b468e](https://github.com/SAP/fiori-for-react/commit/94b468e))
* Updated UI5 WebComponents to v0.11.0 ([#22](https://github.com/SAP/ui5-webcomponents-react/issues/22)) ([7dcf22b](https://github.com/SAP/ui5-webcomponents-react/commit/7dcf22b))
* **FilterBar:** Initial Version ([422bdbd](https://github.com/SAP/ui5-webcomponents-react/commit/422bdbd))
* **FilterItem:** Initial Version ([19a23ec](https://github.com/SAP/ui5-webcomponents-react/commit/19a23ec))
* **VariantManagement:** Initial Version ([a1e9cbb](https://github.com/SAP/ui5-webcomponents-react/commit/a1e9cbb))
* **FilterBar:** renderSearch function ([94b468e](https://github.com/SAP/ui5-webcomponents-react/commit/94b468e))


### Bug Fixes

* **typing:** Fixed TypeScript Definitions ([440c097](https://github.com/SAP/fiori-for-react/commit/440c097))
* **WebComponentWrapper:** Fixed event handler removal after prop update ([2b93c12](https://github.com/SAP/fiori-for-react/commit/2b93c12))
* **typing:** Fixed TypeScript Definitions ([440c097](https://github.com/SAP/ui5-webcomponents-react/commit/440c097))
* **WebComponentWrapper:** Fixed event handler removal after prop update ([2b93c12](https://github.com/SAP/ui5-webcomponents-react/commit/2b93c12))


### BREAKING CHANGES
Expand All @@ -92,10 +92,10 @@ See also [UI5-WebComponents 0.12.0](https://github.com/SAP/ui5-webcomponents/rel

### Bug Fixes

* **web-component-wrapper:** Slots must be passed as camelCase ([1671c17](https://github.com/SAP/fiori-for-react/commit/1671c17))
* **web-component-wrapper:** Slots must be passed as camelCase ([1671c17](https://github.com/SAP/ui5-webcomponents-react/commit/1671c17))


### Features

* **charts:** Added Loading Indicators ([15284b0](https://github.com/SAP/fiori-for-react/commit/15284b0))
* **VariantManagement:** Initial Version ([b8237ce](https://github.com/SAP/fiori-for-react/commit/b8237ce))
* **charts:** Added Loading Indicators ([15284b0](https://github.com/SAP/ui5-webcomponents-react/commit/15284b0))
* **VariantManagement:** Initial Version ([b8237ce](https://github.com/SAP/ui5-webcomponents-react/commit/b8237ce))
18 changes: 9 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
# Contributing to fiori-for-react
# Contributing to ui5-webcomponents-react

You want to contribute to `fiori-for-react`? Welcome! Please read this document to understand what you can do:
You want to contribute to `ui5-webcomponents-react`? Welcome! Please read this document to understand what you can do:
* [Report an Issue](#report-an-issue)
* [Contribute Code](#contribute-code)

## Report an Issue
If you find a bug or some other issue with any part of the library, please [submit an issue](https://github.com/SAP/fiori-for-react/issues). Before doing so, please make sure that:
If you find a bug or some other issue with any part of the library, please [submit an issue](https://github.com/SAP/ui5-webcomponents-react/issues). Before doing so, please make sure that:

- The issue is not a duplicate issue.
- The issue has not been fixed in a newer release of the library.
- The issue is reproducible.
- Your explanation is clear and complete.
- You provide example code and/or screenshots (recommended).

If you meet the above criteria, you can submit issues with our [GitHub issue tracker](https://github.com/SAP/fiori-for-react/issues/new). Please use [labels](#usage-of-labels) to categorize your issue
If you meet the above criteria, you can submit issues with our [GitHub issue tracker](https://github.com/SAP/ui5-webcomponents-react/issues/new). Please use [labels](#usage-of-labels) to categorize your issue

## Feature Requests

Expand Down Expand Up @@ -46,7 +46,7 @@ Status of closed issues:

## Contribute Code

You are welcome to contribute code to `fiori-for-react` in order to fix issues or to add new features.
You are welcome to contribute code to `ui5-webcomponents-react` in order to fix issues or to add new features.

There are two important things to consider:

Expand Down Expand Up @@ -74,14 +74,14 @@ The form contains a list of employees who are authorized to contribute on behalf

### How to contribute - the Process

1. Make sure the issue you've filed in the [issue tracker](https://github.com/SAP/fiori-for-react/issues) has the label "contribution welcome" - otherwise, it is not ready to be worked on.
2. Fork the `fiori-for-react` repository into your GitHub account, create a branch and apply your change. Please don't work directly on the `master` branch of your fork. This will help to update your fork in the future more easily.
1. Make sure the issue you've filed in the [issue tracker](https://github.com/SAP/ui5-webcomponents-react/issues) has the label "contribution welcome" - otherwise, it is not ready to be worked on.
2. Fork the `ui5-webcomponents-react` repository into your GitHub account, create a branch and apply your change. Please don't work directly on the `master` branch of your fork. This will help to update your fork in the future more easily.
3. Commit and push your change on that branch.
Please follow our [Development Conventions and Guidelines](/docs/Guidelines.md).
4. Create a pull request from your branch into `fiori-for-react`-`master` branch.
4. Create a pull request from your branch into `ui5-webcomponents-react`-`master` branch.
5. Follow the link posted by the CLA assistant to your pull request and accept it, as described above.
6. Wait for our code review and approval, possibly enhancing your change on request.
Note that the `fiori-for-react` developers have many duties. So, depending on the required effort for reviewing, testing, and clarification, this may take a while.
Note that the `ui5-webcomponents-react` developers have many duties. So, depending on the required effort for reviewing, testing, and clarification, this may take a while.
7. Once the change has been approved and merged, we will inform you in a comment.
8. Celebrate! 🎉

Expand Down
64 changes: 32 additions & 32 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<a name="top"></a>
# fiori-for-react
# UI5 Web Components for React
<p align="center">
<a href="https://travis-ci.org/SAP/fiori-for-react" target="_blank">
<img alt="Build Status" src="https://img.shields.io/travis/SAP/fiori-for-react/master.svg">
<a href="https://travis-ci.org/SAP/ui5-webcomponents-react" target="_blank">
<img alt="Build Status" src="https://img.shields.io/travis/SAP/ui5-webcomponents-react/master.svg">
</a>
<a href="https://coveralls.io/github/SAP/fiori-for-react" target="_blank">
<img alt="Code Coverage" src="https://img.shields.io/coveralls/github/SAP/fiori-for-react/master.svg">
<a href="https://coveralls.io/github/SAP/ui5-webcomponents-react" target="_blank">
<img alt="Code Coverage" src="https://img.shields.io/coveralls/github/SAP/ui5-webcomponents-react/master.svg">
</a>
<!-- <a href="https://sap-ea.slack.com/messages/CEN48B210" target="_blank">
<img alt="Slack Badge" src="https://badgen.net/badge/slack/fiori-for-react/orange?icon=slack">
<img alt="Slack Badge" src="https://badgen.net/badge/slack/ui5-webcomponents-react/orange?icon=slack">
</a> -->
<a href="https://github.com/prettier/prettier" target="_blank">
<img alt="code style: prettier" src="https://img.shields.io/badge/code_style-prettier-ff69b4.svg">
Expand All @@ -23,32 +23,32 @@
<a name="description"></a>
## Description

`fiori-for-react` is providing a Fiori-compliant React implementation by leveraging the [UI5 Web Components](https://github.com/SAP/ui5-webcomponents).
`ui5-webcomponents-react` is providing a Fiori-compliant React implementation by leveraging the [UI5 Web Components](https://github.com/SAP/ui5-webcomponents).

### Explore our components
You can play around with our components by visiting our [Storybook](https://sap.github.io/fiori-for-react/).
You can play around with our components by visiting our [Storybook](https://sap.github.io/ui5-webcomponents-react/).

### Package Overview

#### [@fiori-for-react/fiori3](https://github.com/SAP/fiori-for-react/tree/master/packages/fiori3) - Fiori 3 Components
[![](https://img.shields.io/npm/v/@fiori-for-react/fiori3.svg)](https://www.npmjs.com/package/@fiori-for-react/fiori3)
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/fiori3](https://img.shields.io/bundlephobia/min/@fiori-for-react/fiori3.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/fiori3](https://img.shields.io/bundlephobia/minzip/@fiori-for-react/fiori3.svg?label=gzip%20size) -->
#### [@ui5-webcomponents-react/fiori3](https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/fiori3) - Fiori 3 Components
[![](https://img.shields.io/npm/v/@ui5-webcomponents-react/fiori3.svg)](https://www.npmjs.com/package/@ui5-webcomponents-react/fiori3)
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/fiori3](https://img.shields.io/bundlephobia/min/@ui5-webcomponents-react/fiori3.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/fiori3](https://img.shields.io/bundlephobia/minzip/@ui5-webcomponents-react/fiori3.svg?label=gzip%20size) -->

#### [@fiori-for-react/styles](https://github.com/SAP/fiori-for-react/tree/master/packages/styles) - Styles
[![](https://img.shields.io/npm/v/@fiori-for-react/styles.svg)](https://www.npmjs.com/package/@fiori-for-react/styles)
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/styles](https://img.shields.io/bundlephobia/min/@fiori-for-react/styles.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/styles](https://img.shields.io/bundlephobia/minzip/@fiori-for-react/styles.svg?label=gzip%20size) -->
#### [@ui5-webcomponents-react/styles](https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/styles) - Styles
[![](https://img.shields.io/npm/v/@ui5-webcomponents-react/styles.svg)](https://www.npmjs.com/package/@ui5-webcomponents-react/styles)
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/styles](https://img.shields.io/bundlephobia/min/@ui5-webcomponents-react/styles.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/styles](https://img.shields.io/bundlephobia/minzip/@ui5-webcomponents-react/styles.svg?label=gzip%20size) -->

#### [@fiori-for-react/utils](https://github.com/SAP/fiori-for-react/tree/master/packages/utils) - Utils
[![](https://img.shields.io/npm/v/@fiori-for-react/utils.svg)](https://www.npmjs.com/package/@fiori-for-react/utils)
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/utils](https://img.shields.io/bundlephobia/min/@fiori-for-react/utils.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/utils](https://img.shields.io/bundlephobia/minzip/@fiori-for-react/utils.svg?label=gzip%20size) -->
#### [@ui5-webcomponents-react/utils](https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/utils) - Utils
[![](https://img.shields.io/npm/v/@ui5-webcomponents-react/utils.svg)](https://www.npmjs.com/package/@ui5-webcomponents-react/utils)
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/utils](https://img.shields.io/bundlephobia/min/@ui5-webcomponents-react/utils.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/utils](https://img.shields.io/bundlephobia/minzip/@ui5-webcomponents-react/utils.svg?label=gzip%20size) -->

#### [@fiori-for-react/charts](https://github.com/SAP/fiori-for-react/tree/master/packages/charts) - Fiori Charts
[![](https://img.shields.io/npm/v/@fiori-for-react/charts.svg)](https://www.npmjs.com/package/@fiori-for-react/charts)
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/charts](https://img.shields.io/bundlephobia/min/@fiori-for-react/charts.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@fiori-for-react/charts](https://img.shields.io/bundlephobia/minzip/@fiori-for-react/charts.svg?label=gzip%20size) -->
#### [@ui5-webcomponents-react/charts](https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/charts) - Fiori Charts
[![](https://img.shields.io/npm/v/@ui5-webcomponents-react/charts.svg)](https://www.npmjs.com/package/@ui5-webcomponents-react/charts)
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/charts](https://img.shields.io/bundlephobia/min/@ui5-webcomponents-react/charts.svg?label=size) -->
<!-- ![https://bundlephobia.com/result?p=@ui5-webcomponents-react/charts](https://img.shields.io/bundlephobia/minzip/@ui5-webcomponents-react/charts.svg?label=gzip%20size) -->


<!-- *********************************************************************** -->
Expand All @@ -63,20 +63,20 @@ You can play around with our components by visiting our [Storybook](https://sap.
<a name="download"></a>
## Download and Installation

To consume `fiori-for-react`, first you need to install the npm module:
To consume `ui5-webcomponents-react`, first you need to install the npm module:
```sh
npm install @fiori-for-react/fiori3 --save
npm install @ui5-webcomponents-react/fiori3 --save
```

<!-- *********************************************************************** -->
<a name="configuration"></a>
## Configuration

**Prerequisite: You have a React app.** In case you don't, we recommend to create one using [create-react-app](https://facebook.github.io/create-react-app/).<br/>
In order to use `fiori-for-react` you have to wrap your application's root component into the `ThemeProvider`.<br/>
In order to use `ui5-webcomponents-react` you have to wrap your application's root component into the `ThemeProvider`.<br/>
You will find this component most likely in `src/App.js`:
```jsx
import { ThemeProvider } from '@fiori-for-react/fiori3/lib/ThemeProvider';
import { ThemeProvider } from '@ui5-webcomponents-react/fiori3/lib/ThemeProvider';
...
render() {
return (
Expand All @@ -89,11 +89,11 @@ render() {
}
```

Then, you are ready to use `fiori-for-react` and you can import the desired component(s) in your app:<br />
Then, you are ready to use `ui5-webcomponents-react` and you can import the desired component(s) in your app:<br />
For example, to use ```Button``` you need to import it:

```jsx
import { Button } from '@fiori-for-react/fiori3/lib/Button'; // loads ui5-button wrapped in a fiori-for-react component
import { Button } from '@ui5-webcomponents-react/fiori3/lib/Button'; // loads ui5-button wrapped in a ui5-webcomponents-react component
```

Then, you can use the Button in your app:
Expand All @@ -102,7 +102,7 @@ Then, you can use the Button in your app:
<Button onPress={() => alert('Hello World!')}>Hello world!</Button>
```

You could import all components also from `@fiori-for-react/fiori3` directly, but this will have a negative impact on your bundle size.
You could import all components also from `@ui5-webcomponents-react/fiori3` directly, but this will have a negative impact on your bundle size.

For Browser Support and the configuration of the UI5 Web Components, please take a look at the
[Browser Support](https://github.com/SAP/ui5-webcomponents#browser-support) and the
Expand Down Expand Up @@ -136,7 +136,7 @@ Please also refer to the [UI5 Web Components React Sample](https://github.com/SA
<a name="issues"></a>
## Known Issues

Please look at our [GitHub Issues](https://github.com/SAP/fiori-for-react/issues) .
Please look at our [GitHub Issues](https://github.com/SAP/ui5-webcomponents-react/issues) .



Expand Down
2 changes: 1 addition & 1 deletion docs/Guidelines.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ might still contain components styled with css modules. It´s planned to migrate
have to use the new styling guidelines. Please see the template, generated by the create-component cli as reference on
how to use react-jss.

Global Styles compliant to the Fiori 2.0 Design Guidelines are located in [fiori-for-react/styles](https://github.com/SAP/fiori-for-react/tree/master/packages/styles).
Global Styles compliant to the Fiori 2.0 Design Guidelines are located in [ui5-webcomponents-react/styles](https://github.com/SAP/ui5-webcomponents-react/tree/master/packages/styles).

## Naming Convention for Props
- All Event handlers **must** start with `on`.<br />
Expand Down
Loading