Skip to content

Navigation Menu

Appearance settings

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

SAP / ui5-webcomponents-react Public

Notifications You must be signed in to change notification settings
Fork 103
Star 496

Code
Issues 36
Pull requests 9
Discussions
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

fix(Modals - TypeScript): allow typing the container element#3856

Merged

Lukas742 merged 4 commits intomainSAP/ui5-webcomponents-react:mainfrom

chore/modals-tscSAP/ui5-webcomponents-react:chore/modals-tscCopy head branch name to clipboard

Dec 9, 2022

Conversation Commits4 (4)Checks Files changed

Commits

Commits on Dec 9, 2022

fix(TypeScript): include `data-*` attributes in `CommonProps` interface
Lukas742
committed
fix(Modals - TypeScript): allow typing the container element
Lukas742
committed
remove data attributes from CommonProps
Lukas742
committed
fix tests
Lukas742
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.