chore: remove react-jss
#5907
Merged
chore: remove react-jss
#5907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -855 B (-0.24%) Total Size: 362 kB
ℹ️ View Unchanged
|
Pull Request Test Coverage Report for Build 9445811726Details
💛 - Coveralls |
BREAKING CHANGE: The `useResponsiveContentPadding` has been removed. You can achieve the same look and feel by using the [responsive content padding from Common CSS](https://sap.github.io/ui5-webcomponents-react/main/?path=/docs/knowledge-base-common-css--docs#content-paddings)
BREAKING CHANGE: UI5 Web Components for React is no longer relying on `react-jss` internally, hence the dependency is now removed and the `react-jss` ThemeProvider is no longer rendered as part of our `ThemeProvider`. If you are relying on `react-jss` in your application, please make sure to render your own `react-jss` ThemeProvider.
Pull Request Test Coverage Report for Build 9446794877Details
💛 - Coveralls |
Lukas742
approved these changes
Jun 13, 2024
Pull Request Test Coverage Report for Build 9501239220Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
🎉 This PR is included in version v2.0.0-rc.0 🎉 The release is available on v2.0.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: UI5 Web Components for React is no longer relying on
react-jssinternally, hence the dependency is now removed and thereact-jssThemeProvider is no longer rendered as part of ourThemeProvider. If you are relying onreact-jssin your application, please make sure to render your ownreact-jssThemeProvider.BREAKING CHANGE: The
useResponsiveContentPaddinghas been removed. You can achieve the same look and feel by using the responsive content padding from Common CSS.