Skip to content

fix(SelectDialog): set search input type to "search" #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix(SelectDialog): set search input type to "search" #6791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/main/src/components/SelectDialog/SelectDialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const Default: Story = {
return (
<ListItemStandard
selected={index === 1}
image={currentProduct.img}
image={<img src={currentProduct.img} alt="Example Image" />}
description={`${currentProduct.description}${index}`}
key={`${currentProduct.text}${index}`}
>
Expand Down Expand Up @@ -156,7 +156,7 @@ export const MultiSelect: Story = {
}
return (
<ListItemStandard
image={currentProduct.img}
image={<img src={currentProduct.img} alt="Example Image" />}
description={`${currentProduct.description}${index}`}
data-description={`${currentProduct.description}${index}`}
key={`${currentProduct.text}${index}`}
Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/components/SelectDialog/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import ButtonDesign from '@ui5/webcomponents/dist/types/ButtonDesign.js';
import IconMode from '@ui5/webcomponents/dist/types/IconMode.js';
import InputType from '@ui5/webcomponents/dist/types/InputType.js';
import ListSelectionMode from '@ui5/webcomponents/dist/types/ListSelectionMode.js';
import iconDecline from '@ui5/webcomponents-icons/dist/decline.js';
import iconSearch from '@ui5/webcomponents-icons/dist/search.js';
Expand Down Expand Up @@ -306,6 +307,7 @@ const SelectDialog = forwardRef<DialogDomRef, SelectDialogPropTypes>((props, ref
placeholder={i18nBundle.getText(SEARCH)}
onInput={handleSearchInput}
onKeyUp={handleSearchSubmit}
type={InputType.Search}
icon={
<>
{searchValue && (
Expand Down
Loading