Skip to content

refactor(Text): Replace withStyles HOC with forwardRef implementation #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2019
Merged

refactor(Text): Replace withStyles HOC with forwardRef implementation #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bfdbfa
refactor(Text): Replace withStyles HOC with forwardRef implementation
MarcusNotheis Jul 24, 2019
9cf19d2
WIP: Fixed Typo
MarcusNotheis Jul 24, 2019
d36f103
WIP: Updated Tests
MarcusNotheis Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions packages/main/__karma_snapshots__/AnalyticalCard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,11 @@
</ui5-label>
</Label>
<div>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Target
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Target
</span>
</Text>
</div>
</div>
<div className="AnalyticalCardHeader-deviation---">
Expand All @@ -59,13 +57,11 @@
</ui5-label>
</Label>
<div>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Deviation
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Deviation
</span>
</Text>
</div>
</div>
</div>
Expand All @@ -78,13 +74,11 @@
</AnalyticalCardHeader>
</WithStyles(AnalyticalCardHeader)>
<div style={{...}}>
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
I&#39;m a content!
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
I&#39;m a content!
</span>
</Text>
</div>
</div>
</AnalyticalCard>
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/CustomListItem.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<CustomListItem type="Active">
<ui5-li-custom type="Active" class="" />
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/DatePicker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<DatePicker valueState="None">
<ui5-datepicker value-state="None" class="" />
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/Dialog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<Dialog initialFocus={{...}} headerText="">
<WithWebComponent(Dialog) initialFocus={{...}} headerText="">
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/Icon.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<Icon>
<ui5-icon class="" />
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/Label.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<Label for="">
<ui5-label for="" class="" />
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/List.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<WithWebComponent(List) headerText="" footerText="" mode="None" noDataText="" separators="All">
<ui5-list header-text="" footer-text="" mode="None" no-data-text="" separators="All" class="" />
Expand Down
108 changes: 45 additions & 63 deletions packages/main/__karma_snapshots__/MessageBox.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Confirm - OK
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Confirm - OK
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -79,13 +77,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Confirm - Cancel
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Confirm - Cancel
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -135,13 +131,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Success
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Success
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -184,13 +178,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Warning
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Warning
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -233,13 +225,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Error
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Error
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="Close">
Expand Down Expand Up @@ -282,13 +272,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Information
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Information
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -331,13 +319,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Custom
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Custom
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="Yes">
Expand Down Expand Up @@ -387,13 +373,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
Custom Success
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
Custom Success
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down Expand Up @@ -450,13 +434,11 @@
</Title>
</header>
<section className="MessageBox-content---">
<WithStyles(Component) renderWhitespace={false} wrapping={true} width={{...}}>
<Component renderWhitespace={false} wrapping={true} width={{...}} innerRef={{...}} classes={{...}} theme={{...}}>
<span style={{...}} className="Component-text---" title={[undefined]} slot={[undefined]}>
No Title
</span>
</Component>
</WithStyles(Component)>
<Text renderWhitespace={false} wrapping={true} width={{...}}>
<span style={{...}} className="Text--text---" title={[undefined]} slot={[undefined]}>
No Title
</span>
</Text>
</section>
<footer className="MessageBox-footer---">
<MessageBoxButton emphasize={true} onClick={[Function]} action="OK">
Expand Down
2 changes: 1 addition & 1 deletion packages/main/__karma_snapshots__/MonthPicker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

```
<ThemeProvider withToastContainer={false}>
<JssProvider generateId={[Function]} id={{...}}>
<JssProvider generateId={[Function]}>
<ThemeProvider theme={{...}}>
<MonthPicker>
<ui5-month-picker class="" />
Expand Down
Loading