Skip to content

fix(Toolbar - compat): prevent empty overflow popover #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix(Toolbar - compat): prevent empty overflow popover #7185

merged 2 commits into from
Apr 7, 2025

Conversation

Lukas742
Copy link
Contributor

@Lukas742 Lukas742 commented Apr 3, 2025

If only ToolbarSeparator or ToolbarSpacer components are passed to the Toolbar, the components won't be rendered to prevent an empty overflow popover to show up if the width of the Toolbar is very small.

@Lukas742 Lukas742 requested a review from MarcusNotheis as a code owner April 3, 2025 12:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

Size Change: +103 B (+0.02%)

Total Size: 417 kB

Filename Size Change
packages/compat/dist/components/Toolbar/index.js 3.23 kB +98 B (+3.13%)
packages/compat/dist/css/index.css 1.08 kB +5 B (+0.46%)
ℹ️ View Unchanged
Filename Size
packages/ai/dist/components/Button/index.js 882 B
packages/ai/dist/components/ButtonState/index.js 549 B
packages/ai/dist/components/PromptInput/index.js 546 B
packages/ai/dist/generated/VersionInfo.js 149 B
packages/ai/dist/index.js 103 B
packages/base/dist/Device/EventProvider.js 136 B
packages/base/dist/Device/index.js 1.8 kB
packages/base/dist/Device/Media.js 884 B
packages/base/dist/generated/VersionInfo.js 149 B
packages/base/dist/hooks/index.js 187 B
packages/base/dist/hooks/useCurrentTheme.js 275 B
packages/base/dist/hooks/useI18nBundle.js 281 B
packages/base/dist/hooks/useIsomorphicLayoutEffect.js 137 B
packages/base/dist/hooks/useIsRTL.js 398 B
packages/base/dist/hooks/useStylesheet.js 491 B
packages/base/dist/hooks/useSyncRef.js 247 B
packages/base/dist/hooks/useViewportRange.js 295 B
packages/base/dist/index.js 255 B
packages/base/dist/stores/I18nStore.js 625 B
packages/base/dist/stores/StyleStore.js 596 B
packages/base/dist/styling/CssSizeVariables.js 942 B
packages/base/dist/styling/ThemingParameters.js 10.2 kB
packages/base/dist/types/CommonProps.js 31 B
packages/base/dist/types/index.js 31 B
packages/base/dist/types/Ui5CustomEvent.js 31 B
packages/base/dist/types/Ui5DomRef.js 31 B
packages/base/dist/utils/addCustomCSSWithScoping.js 216 B
packages/base/dist/utils/debounce.js 639 B
packages/base/dist/utils/index.js 1.03 kB
packages/base/dist/utils/throttle.js 822 B
packages/base/dist/wrapper/withWebComponent.js 2.41 kB
packages/charts/dist/components/BarChart/BarChart.js 2.87 kB
packages/charts/dist/components/BarChart/Placeholder.js 451 B
packages/charts/dist/components/BulletChart/BulletChart.js 3.59 kB
packages/charts/dist/components/BulletChart/ComparisonLine.js 359 B
packages/charts/dist/components/BulletChart/Placeholder.js 763 B
packages/charts/dist/components/ColumnChart/ColumnChart.js 2.86 kB
packages/charts/dist/components/ColumnChart/Placeholder.js 477 B
packages/charts/dist/components/ColumnChartWithTrend/ColumnChartWithTrend.js 1.45 kB
packages/charts/dist/components/ColumnChartWithTrend/Placeholder.js 565 B
packages/charts/dist/components/ComposedChart/index.js 3.65 kB
packages/charts/dist/components/ComposedChart/Placeholder.js 866 B
packages/charts/dist/components/DonutChart/DonutChart.js 428 B
packages/charts/dist/components/LineChart/LineChart.js 2.64 kB
packages/charts/dist/components/LineChart/Placeholder.js 502 B
packages/charts/dist/components/PieChart/PieChart.js 2.99 kB
packages/charts/dist/components/PieChart/PieChart.module.css.js 270 B
packages/charts/dist/components/PieChart/Placeholder.js 409 B
packages/charts/dist/components/RadarChart/RadarChart.js 1.73 kB
packages/charts/dist/components/RadialChart/RadialChart.js 1.07 kB
packages/charts/dist/components/ScatterChart/Placeholder.js 502 B
packages/charts/dist/components/ScatterChart/ScatterChart.js 2.41 kB
packages/charts/dist/components/TimelineChart/chartbody/TimelineChartBody.js 1.88 kB
packages/charts/dist/components/TimelineChart/chartbody/TimelineChartGrid.js 1.04 kB
packages/charts/dist/components/TimelineChart/chartbody/TimelineChartLayer.js 526 B
packages/charts/dist/components/TimelineChart/chartbody/TimelineChartRow.js 1.68 kB
packages/charts/dist/components/TimelineChart/chartbody/TimelineConnections.js 1.75 kB
packages/charts/dist/components/TimelineChart/examples/Annotations.js 10.8 kB
packages/charts/dist/components/TimelineChart/examples/Dataset.js 775 B
packages/charts/dist/components/TimelineChart/Placeholder.js 468 B
packages/charts/dist/components/TimelineChart/TimelineChart.js 2.38 kB
packages/charts/dist/components/TimelineChart/TimelineChartAnnotation.js 538 B
packages/charts/dist/components/TimelineChart/TimelineChartHeaders.js 1.56 kB
packages/charts/dist/components/TimelineChart/types/TimelineChartTypes.js 151 B
packages/charts/dist/components/TimelineChart/util/constants.js 612 B
packages/charts/dist/components/TimelineChart/util/context.js 112 B
packages/charts/dist/components/TimelineChart/util/error.js 148 B
packages/charts/dist/components/TimelineChart/util/TimelineChart.module.css.js 784 B
packages/charts/dist/css/components/PieChart/PieChart.module.css 210 B
packages/charts/dist/css/components/TimelineChart/util/TimelineChart.module.css 580 B
packages/charts/dist/css/index.css 869 B
packages/charts/dist/css/internal/ChartContainer.module.css 310 B
packages/charts/dist/generated/VersionInfo.js 149 B
packages/charts/dist/hooks/useCancelAnimationFallback.js 291 B
packages/charts/dist/hooks/useChartMargin.js 195 B
packages/charts/dist/hooks/useLabelFormatter.js 182 B
packages/charts/dist/hooks/useLegendItemClick.js 335 B
packages/charts/dist/hooks/useLongestYAxisLabel.js 479 B
packages/charts/dist/hooks/useLongestYAxisLabelBar.js 566 B
packages/charts/dist/hooks/useObserveXAxisHeights.js 613 B
packages/charts/dist/hooks/useOnClickInternal.js 248 B
packages/charts/dist/hooks/usePrepareDimensionsAndMeasures.js 333 B
packages/charts/dist/hooks/usePrepareTrendMeasures.js 536 B
packages/charts/dist/hooks/useTooltipFormatter.js 225 B
packages/charts/dist/index.js 398 B
packages/charts/dist/interfaces/ICartesianChartConfig.js 31 B
packages/charts/dist/interfaces/IChartBaseProps.js 31 B
packages/charts/dist/interfaces/IChartDimension.js 31 B
packages/charts/dist/interfaces/IChartMeasure.js 31 B
packages/charts/dist/interfaces/IPolarChartConfig.js 31 B
packages/charts/dist/internal/ChartContainer.js 900 B
packages/charts/dist/internal/ChartContainer.module.css.js 385 B
packages/charts/dist/internal/ChartDataLabel.js 525 B
packages/charts/dist/internal/defaults.js 86 B
packages/charts/dist/internal/staticProps.js 280 B
packages/charts/dist/internal/Utils.js 623 B
packages/charts/dist/internal/XAxisTicks.js 599 B
packages/charts/dist/internal/YAxisTicks.js 505 B
packages/charts/dist/resources/DemoProps.js 2.08 kB
packages/cli/dist/bin/index.js 822 B
packages/cli/dist/scripts/codemod/main.js 606 B
packages/cli/dist/scripts/create-wrappers/AbstractRenderer.js 206 B
packages/cli/dist/scripts/create-wrappers/AttributesRenderer.js 1.14 kB
packages/cli/dist/scripts/create-wrappers/ComponentRenderer.js 883 B
packages/cli/dist/scripts/create-wrappers/DomRefRenderer.js 1.88 kB
packages/cli/dist/scripts/create-wrappers/ExportsRenderer.js 204 B
packages/cli/dist/scripts/create-wrappers/ImportsRenderer.js 598 B
packages/cli/dist/scripts/create-wrappers/main.js 987 B
packages/cli/dist/scripts/create-wrappers/PropTypesRenderer.js 2.21 kB
packages/cli/dist/scripts/create-wrappers/WebComponentWrapper.js 676 B
packages/cli/dist/scripts/resolve-cem/main.js 223 B
packages/cli/dist/util/cem-reader.js 340 B
packages/cli/dist/util/formatters.js 675 B
packages/cli/dist/util/recursiveManifestResolver.js 813 B
packages/cli/dist/util/referenceResolver.js 547 B
packages/compat/dist/components/Loader/index.js 1.01 kB
packages/compat/dist/components/Loader/Loader.module.css.js 424 B
packages/compat/dist/components/OverflowToolbarButton/index.js 425 B
packages/compat/dist/components/OverflowToolbarToggleButton/index.js 432 B
packages/compat/dist/components/Table/index.js 1.54 kB
packages/compat/dist/components/TableCell/index.js 325 B
packages/compat/dist/components/TableColumn/index.js 376 B
packages/compat/dist/components/TableGroupRow/index.js 356 B
packages/compat/dist/components/TableRow/index.js 327 B
packages/compat/dist/components/Toolbar/OverflowPopover.js 1.92 kB
packages/compat/dist/components/Toolbar/Toolbar.module.css.js 1 kB
packages/compat/dist/components/ToolbarSeparator/index.js 435 B
packages/compat/dist/components/ToolbarSeparator/ToolbarSeparator.module.css.js 207 B
packages/compat/dist/components/ToolbarSpacer/index.js 342 B
packages/compat/dist/css/components/Loader/Loader.module.css 337 B
packages/compat/dist/css/components/Toolbar/Toolbar.module.css 833 B
packages/compat/dist/css/components/ToolbarSeparator/ToolbarSeparator.module.css 142 B
packages/compat/dist/enums/LoaderType.js 116 B
packages/compat/dist/enums/ToolbarDesign.js 140 B
packages/compat/dist/enums/ToolbarStyle.js 116 B
packages/compat/dist/generated/VersionInfo.js 150 B
packages/compat/dist/index.js 233 B
packages/compat/dist/internal/OverflowPopoverContext.js 225 B
packages/cypress-commands/dist/commands.js 775 B
packages/cypress-commands/dist/index.js 54 B
packages/cypress-commands/dist/queries.js 877 B
packages/main/dist/Assets-static.js 82 B
packages/main/dist/Assets.js 100 B
packages/main/dist/components/ActionSheet/ActionSheet.module.css.js 472 B
packages/main/dist/components/ActionSheet/index.js 2.29 kB
packages/main/dist/components/AnalyticalCardHeader/AnalyticalCardHeader.module.css.js 1.29 kB
packages/main/dist/components/AnalyticalCardHeader/index.js 1.73 kB
packages/main/dist/components/AnalyticalTable/AnalyticalTable.module.css.js 2.96 kB
packages/main/dist/components/AnalyticalTable/ColumnHeader/ColumnHeaderContainer.js 900 B
packages/main/dist/components/AnalyticalTable/ColumnHeader/index.js 1.79 kB
packages/main/dist/components/AnalyticalTable/defaults/Column/Cell.js 309 B
packages/main/dist/components/AnalyticalTable/defaults/Column/ColumnHeaderModal.js 2.07 kB
packages/main/dist/components/AnalyticalTable/defaults/Column/Expandable.js 1.22 kB
packages/main/dist/components/AnalyticalTable/defaults/Column/Grouped.js 628 B
packages/main/dist/components/AnalyticalTable/defaults/Column/index.js 342 B
packages/main/dist/components/AnalyticalTable/defaults/Column/PopIn.js 1.01 kB
packages/main/dist/components/AnalyticalTable/defaults/Column/RepeatedValue.js 60 B
packages/main/dist/components/AnalyticalTable/defaults/FilterComponent/index.js 410 B
packages/main/dist/components/AnalyticalTable/defaults/LoadingComponent/TablePlaceholder.js 595 B
packages/main/dist/components/AnalyticalTable/defaults/LoadingComponent/TablePlaceholder.module.css.js 500 B
packages/main/dist/components/AnalyticalTable/defaults/NoDataComponent/index.js 188 B
packages/main/dist/components/AnalyticalTable/hooks/useA11y.js 1.21 kB
packages/main/dist/components/AnalyticalTable/hooks/useAutoResize.js 1.36 kB
packages/main/dist/components/AnalyticalTable/hooks/useDragAndDrop.js 835 B
packages/main/dist/components/AnalyticalTable/hooks/useDynamicColumnWidths.js 3.16 kB
packages/main/dist/components/AnalyticalTable/hooks/useKeyboardNavigation.js 2.77 kB
packages/main/dist/components/AnalyticalTable/hooks/usePopIn.js 565 B
packages/main/dist/components/AnalyticalTable/hooks/useResizeColumnsConfig.js 188 B
packages/main/dist/components/AnalyticalTable/hooks/useRowHighlight.js 887 B
packages/main/dist/components/AnalyticalTable/hooks/useRowNavigationIndicator.js 706 B
packages/main/dist/components/AnalyticalTable/hooks/useRowSelectionColumn.js 1.95 kB
packages/main/dist/components/AnalyticalTable/hooks/useSelectionChangeCallback.js 841 B
packages/main/dist/components/AnalyticalTable/hooks/useSingleRowStateSelection.js 1.06 kB
packages/main/dist/components/AnalyticalTable/hooks/useStyling.js 1 kB
packages/main/dist/components/AnalyticalTable/hooks/useTableScrollHandles.js 468 B
packages/main/dist/components/AnalyticalTable/hooks/useToggleRowExpand.js 702 B
packages/main/dist/components/AnalyticalTable/hooks/useVisibleColumnsWidth.js 180 B
packages/main/dist/components/AnalyticalTable/index.js 6.9 kB
packages/main/dist/components/AnalyticalTable/pluginHooks/AnalyticalTableHooks.js 190 B
packages/main/dist/components/AnalyticalTable/pluginHooks/useAnnounceEmptyCells.js 519 B
packages/main/dist/components/AnalyticalTable/pluginHooks/useIndeterminateRowSelection.js 1.74 kB
packages/main/dist/components/AnalyticalTable/pluginHooks/useManualRowSelect.js 443 B
packages/main/dist/components/AnalyticalTable/pluginHooks/useOnColumnResize.js 765 B
packages/main/dist/components/AnalyticalTable/pluginHooks/useOrderedMultiSort.js 546 B
packages/main/dist/components/AnalyticalTable/pluginHooks/useRowDisableSelection.js 1.73 kB
packages/main/dist/components/AnalyticalTable/scrollbars/VerticalScrollbar.js 908 B
packages/main/dist/components/AnalyticalTable/TableBody/EmptyRow.js 280 B
packages/main/dist/components/AnalyticalTable/TableBody/RowSubComponent.js 1.18 kB
packages/main/dist/components/AnalyticalTable/TableBody/VirtualTableBody.js 2.28 kB
packages/main/dist/components/AnalyticalTable/TableBody/VirtualTableBodyContainer.js 1.21 kB
packages/main/dist/components/AnalyticalTable/tableReducer/stateReducer.js 1.04 kB
packages/main/dist/components/AnalyticalTable/TitleBar/index.js 377 B
packages/main/dist/components/AnalyticalTable/types/index.js 206 B
packages/main/dist/components/AnalyticalTable/util/index.js 1.66 kB
packages/main/dist/components/AnalyticalTable/VerticalResizer.js 1.41 kB
packages/main/dist/components/FilterBar/FilterBar.module.css.js 811 B
packages/main/dist/components/FilterBar/FilterBarDialog.module.css.js 741 B
packages/main/dist/components/FilterBar/FilterDialog.js 4.97 kB
packages/main/dist/components/FilterBar/index.js 3.92 kB
packages/main/dist/components/FilterBar/types.js 30 B
packages/main/dist/components/FilterGroupItem/FilterGroupItem.module.css.js 806 B
packages/main/dist/components/FilterGroupItem/index.js 2.67 kB
packages/main/dist/components/FilterGroupItem/types.js 30 B
packages/main/dist/components/FlexBox/FlexBox.module.css.js 626 B
packages/main/dist/components/FlexBox/index.js 625 B
packages/main/dist/components/Grid/Grid.module.css.js 415 B
packages/main/dist/components/Grid/index.js 1.33 kB
packages/main/dist/components/MessageBox/index.js 2.13 kB
packages/main/dist/components/MessageBox/MessageBox.module.css.js 542 B
packages/main/dist/components/MessageView/index.js 2.18 kB
packages/main/dist/components/MessageView/MessageItem.js 1.45 kB
packages/main/dist/components/MessageView/MessageItem.module.css.js 787 B
packages/main/dist/components/MessageView/MessageView.module.css.js 606 B
packages/main/dist/components/MessageView/utils.js 273 B
packages/main/dist/components/MessageViewButton/index.js 848 B
packages/main/dist/components/MessageViewButton/MessageViewButton.module.css.js 506 B
packages/main/dist/components/Modals/index.js 1.25 kB
packages/main/dist/components/NumericSideIndicator/index.js 533 B
packages/main/dist/components/NumericSideIndicator/NumericSideIndicator.module.css.js 493 B
packages/main/dist/components/ObjectPage/CollapsedAvatar.js 699 B
packages/main/dist/components/ObjectPage/CollapsedAvatar.module.css.js 321 B
packages/main/dist/components/ObjectPage/index.js 6.29 kB
packages/main/dist/components/ObjectPage/ObjectPage.module.css.js 1.32 kB
packages/main/dist/components/ObjectPage/ObjectPageUtils.js 284 B
packages/main/dist/components/ObjectPageAnchorBar/index.js 1.54 kB
packages/main/dist/components/ObjectPageAnchorBar/ObjectPageAnchorBar.module.css.js 521 B
packages/main/dist/components/ObjectPageHeader/index.js 644 B
packages/main/dist/components/ObjectPageHeader/ObjectPageHeader.module.css.js 251 B
packages/main/dist/components/ObjectPageSection/index.js 679 B
packages/main/dist/components/ObjectPageSection/ObjectPageSection.module.css.js 591 B
packages/main/dist/components/ObjectPageSubSection/index.js 908 B
packages/main/dist/components/ObjectPageSubSection/ObjectPageSubSection.module.css.js 513 B
packages/main/dist/components/ObjectPageTitle/ActionsSpacer.js 309 B
packages/main/dist/components/ObjectPageTitle/index.js 2.13 kB
packages/main/dist/components/ObjectPageTitle/ObjectPageTitle.module.css.js 1 kB
packages/main/dist/components/ObjectStatus/index.js 1.78 kB
packages/main/dist/components/ObjectStatus/ObjectStatus.module.css.js 2.18 kB
packages/main/dist/components/ResponsiveGridLayout/index.js 743 B
packages/main/dist/components/ResponsiveGridLayout/ResponsiveGridLayout.module.css.js 301 B
packages/main/dist/components/SelectDialog/index.js 2.01 kB
packages/main/dist/components/SelectDialog/SelectDialog.module.css.js 814 B
packages/main/dist/components/Splitter/index.js 2.44 kB
packages/main/dist/components/Splitter/Splitter.module.css.js 884 B
packages/main/dist/components/SplitterElement/index.js 1.19 kB
packages/main/dist/components/SplitterElement/SplitterElement.module.css.js 212 B
packages/main/dist/components/SplitterLayout/index.js 1.34 kB
packages/main/dist/components/SplitterLayout/SplitterLayout.module.css.js 278 B
packages/main/dist/components/SplitterLayout/useConcatSplitterElements.js 736 B
packages/main/dist/components/ThemeProvider/index.js 1.18 kB
packages/main/dist/components/ThemeProvider/Sizes.css.js 590 B
packages/main/dist/components/ThemeProvider/ThemeProvider.css.js 1.55 kB
packages/main/dist/components/VariantManagement/index.js 3.99 kB
packages/main/dist/components/VariantManagement/ManageViewsDialog.js 2.4 kB
packages/main/dist/components/VariantManagement/ManageViewsDialog.module.css.js 506 B
packages/main/dist/components/VariantManagement/ManageViewsTableRows.js 1.97 kB
packages/main/dist/components/VariantManagement/SaveViewDialog.js 1.77 kB
packages/main/dist/components/VariantManagement/SaveViewDialog.module.css.js 258 B
packages/main/dist/components/VariantManagement/types.js 30 B
packages/main/dist/components/VariantManagement/VariantItem.js 808 B
packages/main/dist/components/VariantManagement/VariantItem.module.css.js 166 B
packages/main/dist/components/VariantManagement/VariantManagement.module.css.js 641 B
packages/main/dist/css/components/ActionSheet/ActionSheet.module.css 391 B
packages/main/dist/css/components/AnalyticalCardHeader/AnalyticalCardHeader.module.css 1.05 kB
packages/main/dist/css/components/AnalyticalTable/AnalyticalTable.module.css 2.36 kB
packages/main/dist/css/components/AnalyticalTable/defaults/LoadingComponent/TablePlaceholder.module.css 402 B
packages/main/dist/css/components/FilterBar/FilterBar.module.css 638 B
packages/main/dist/css/components/FilterBar/FilterBarDialog.module.css 576 B
packages/main/dist/css/components/FilterGroupItem/FilterGroupItem.module.css 641 B
packages/main/dist/css/components/FlexBox/FlexBox.module.css 404 B
packages/main/dist/css/components/Grid/Grid.module.css 257 B
packages/main/dist/css/components/MessageBox/MessageBox.module.css 448 B
packages/main/dist/css/components/MessageView/MessageItem.module.css 608 B
packages/main/dist/css/components/MessageView/MessageView.module.css 472 B
packages/main/dist/css/components/MessageViewButton/MessageViewButton.module.css 438 B
packages/main/dist/css/components/NumericSideIndicator/NumericSideIndicator.module.css 376 B
packages/main/dist/css/components/ObjectPage/CollapsedAvatar.module.css 221 B
packages/main/dist/css/components/ObjectPage/ObjectPage.module.css 1.1 kB
packages/main/dist/css/components/ObjectPageAnchorBar/ObjectPageAnchorBar.module.css 419 B
packages/main/dist/css/components/ObjectPageHeader/ObjectPageHeader.module.css 185 B
packages/main/dist/css/components/ObjectPageSection/ObjectPageSection.module.css 468 B
packages/main/dist/css/components/ObjectPageSubSection/ObjectPageSubSection.module.css 404 B
packages/main/dist/css/components/ObjectPageTitle/ObjectPageTitle.module.css 835 B
packages/main/dist/css/components/ObjectStatus/ObjectStatus.module.css 1.93 kB
packages/main/dist/css/components/ResponsiveGridLayout/ResponsiveGridLayout.module.css 236 B
packages/main/dist/css/components/SelectDialog/SelectDialog.module.css 676 B
packages/main/dist/css/components/Splitter/Splitter.module.css 775 B
packages/main/dist/css/components/SplitterElement/SplitterElement.module.css 145 B
packages/main/dist/css/components/SplitterLayout/SplitterLayout.module.css 217 B
packages/main/dist/css/components/ThemeProvider/Sizes.css 539 B
packages/main/dist/css/components/ThemeProvider/ThemeProvider.css 1.5 kB
packages/main/dist/css/components/VariantManagement/ManageViewsDialog.module.css 412 B
packages/main/dist/css/components/VariantManagement/SaveViewDialog.module.css 172 B
packages/main/dist/css/components/VariantManagement/VariantItem.module.css 101 B
packages/main/dist/css/components/VariantManagement/VariantManagement.module.css 494 B
packages/main/dist/css/index.css 12.3 kB
packages/main/dist/css/internal/DynamicPageStickyHeader.css 107 B
packages/main/dist/css/themes/base.css 528 B
packages/main/dist/css/themes/sap_belize_hcb.css 195 B
packages/main/dist/css/themes/sap_belize_hcw.css 198 B
packages/main/dist/css/themes/sap_belize.css 228 B
packages/main/dist/css/themes/sap_fiori_3_dark.css 220 B
packages/main/dist/css/themes/sap_fiori_3_hcb.css 292 B
packages/main/dist/css/themes/sap_fiori_3_hcw.css 292 B
packages/main/dist/css/themes/sap_fiori_3.css 217 B
packages/main/dist/css/themes/sap_horizon_dark.css 435 B
packages/main/dist/css/themes/sap_horizon_hcb.css 491 B
packages/main/dist/css/themes/sap_horizon_hcw.css 491 B
packages/main/dist/css/themes/sap_horizon.css 432 B
packages/main/dist/enums/AnalyticalTablePopinDisplay.js 301 B
packages/main/dist/enums/AnalyticalTableScaleWidthMode.js 816 B
packages/main/dist/enums/AnalyticalTableScrollMode.js 358 B
packages/main/dist/enums/AnalyticalTableSelectionBehavior.js 283 B
packages/main/dist/enums/AnalyticalTableSelectionMode.js 262 B
packages/main/dist/enums/AnalyticalTableSubComponentsBehavior.js 514 B
packages/main/dist/enums/AnalyticalTableVisibleRowCountMode.js 521 B
packages/main/dist/enums/ContentDensity.js 123 B
packages/main/dist/enums/DeviationIndicator.js 132 B
packages/main/dist/enums/FlexBoxAlignItems.js 300 B
packages/main/dist/enums/FlexBoxDirection.js 274 B
packages/main/dist/enums/FlexBoxJustifyContent.js 354 B
packages/main/dist/enums/FlexBoxWrap.js 246 B
packages/main/dist/enums/GridPosition.js 129 B
packages/main/dist/enums/index.js 270 B
packages/main/dist/enums/IndicationColor.js 305 B
packages/main/dist/enums/MessageBoxAction.js 182 B
packages/main/dist/enums/MessageBoxType.js 167 B
packages/main/dist/enums/ObjectPageMode.js 241 B
packages/main/dist/enums/Size.js 124 B
packages/main/dist/enums/TextAlign.js 159 B
packages/main/dist/enums/Theme.js 168 B
packages/main/dist/enums/ValueColor.js 246 B
packages/main/dist/enums/VerticalAlign.js 147 B
packages/main/dist/generated/VersionInfo.js 148 B
packages/main/dist/i18n/i18n-defaults.js 2.67 kB
packages/main/dist/index.js 438 B
packages/main/dist/internal/ContainerQueries.js 210 B
packages/main/dist/internal/DynamicPageStickyHeader.css.js 154 B
packages/main/dist/internal/FilterBarDialogContext.js 108 B
packages/main/dist/internal/getRandomId.js 220 B
packages/main/dist/internal/MessageViewContext.js 128 B
packages/main/dist/internal/ModalStore.js 468 B
packages/main/dist/internal/OverflowPopoverContext.js 239 B
packages/main/dist/internal/safeGetChildrenArray.js 183 B
packages/main/dist/internal/SplitterLayoutContext.js 136 B
packages/main/dist/internal/stopPropagation.js 86 B
packages/main/dist/internal/useObserveHeights.js 928 B
packages/main/dist/internal/utils.js 682 B
packages/main/dist/internal/VariantManagementContext.js 150 B
packages/main/dist/internal/withWebComponent.js 79 B
packages/main/dist/json-imports/i18n-fetch.js 1 kB
packages/main/dist/json-imports/i18n.js 1.2 kB
packages/main/dist/themes/base.css.js 581 B
packages/main/dist/themes/CustomVariables.js 628 B
packages/main/dist/themes/sap_belize_hcb.css.js 247 B
packages/main/dist/themes/sap_belize_hcw.css.js 248 B
packages/main/dist/themes/sap_belize.css.js 275 B
packages/main/dist/themes/sap_fiori_3_dark.css.js 267 B
packages/main/dist/themes/sap_fiori_3_hcb.css.js 341 B
packages/main/dist/themes/sap_fiori_3_hcw.css.js 341 B
packages/main/dist/themes/sap_fiori_3.css.js 264 B
packages/main/dist/themes/sap_horizon_dark.css.js 484 B
packages/main/dist/themes/sap_horizon_hcb.css.js 541 B
packages/main/dist/themes/sap_horizon_hcw.css.js 541 B
packages/main/dist/themes/sap_horizon.css.js 481 B
packages/main/dist/types/CommonProps.js 30 B
packages/main/dist/types/index.js 30 B
packages/main/dist/types/Ui5CustomEvent.js 30 B
packages/main/dist/types/Ui5DomRef.js 30 B
packages/main/dist/webComponents/Avatar/index.js 609 B
packages/main/dist/webComponents/AvatarGroup/index.js 1.06 kB
packages/main/dist/webComponents/Bar/index.js 873 B
packages/main/dist/webComponents/BarcodeScannerDialog/index.js 594 B
packages/main/dist/webComponents/Breadcrumbs/index.js 773 B
packages/main/dist/webComponents/BreadcrumbsItem/index.js 341 B
packages/main/dist/webComponents/BusyIndicator/index.js 847 B
packages/main/dist/webComponents/Button/index.js 702 B
packages/main/dist/webComponents/ButtonBadge/index.js 359 B
packages/main/dist/webComponents/Calendar/index.js 1.46 kB
packages/main/dist/webComponents/CalendarDate/index.js 316 B
packages/main/dist/webComponents/CalendarDateRange/index.js 375 B
packages/main/dist/webComponents/CalendarLegend/index.js 461 B
packages/main/dist/webComponents/CalendarLegendItem/index.js 532 B
packages/main/dist/webComponents/Card/index.js 539 B
packages/main/dist/webComponents/CardHeader/index.js 503 B
packages/main/dist/webComponents/Carousel/index.js 924 B
packages/main/dist/webComponents/CheckBox/index.js 856 B
packages/main/dist/webComponents/ColorPalette/index.js 438 B
packages/main/dist/webComponents/ColorPaletteItem/index.js 320 B
packages/main/dist/webComponents/ColorPalettePopover/index.js 656 B
packages/main/dist/webComponents/ColorPicker/index.js 459 B
packages/main/dist/webComponents/ComboBox/index.js 936 B
packages/main/dist/webComponents/ComboBoxItem/index.js 314 B
packages/main/dist/webComponents/ComboBoxItemGroup/index.js 387 B
packages/main/dist/webComponents/DatePicker/index.js 1.57 kB
packages/main/dist/webComponents/DateRangePicker/index.js 819 B
packages/main/dist/webComponents/DateTimePicker/index.js 1.32 kB
packages/main/dist/webComponents/Dialog/index.js 1.26 kB
packages/main/dist/webComponents/DynamicPage/helpers.js 496 B
packages/main/dist/webComponents/DynamicPage/index.js 1.49 kB
packages/main/dist/webComponents/DynamicPageHeader/index.js 580 B
packages/main/dist/webComponents/DynamicPageTitle/index.js 736 B
packages/main/dist/webComponents/DynamicSideContent/index.js 1.49 kB
packages/main/dist/webComponents/ExpandableText/index.js 985 B
packages/main/dist/webComponents/FileUploader/index.js 651 B
packages/main/dist/webComponents/FilterItem/index.js 328 B
packages/main/dist/webComponents/FilterItemOption/index.js 324 B
packages/main/dist/webComponents/FlexibleColumnLayout/index.js 1.16 kB
packages/main/dist/webComponents/Form/index.js 2.48 kB
packages/main/dist/webComponents/FormGroup/index.js 588 B
packages/main/dist/webComponents/FormItem/index.js 464 B
packages/main/dist/webComponents/Icon/index.js 1.2 kB
packages/main/dist/webComponents/IllustratedMessage/index.js 874 B
packages/main/dist/webComponents/index.js 840 B
packages/main/dist/webComponents/Input/index.js 1.05 kB
packages/main/dist/webComponents/Label/index.js 550 B
packages/main/dist/webComponents/Link/index.js 880 B
packages/main/dist/webComponents/List/index.js 1.09 kB
packages/main/dist/webComponents/ListItemCustom/index.js 448 B
packages/main/dist/webComponents/ListItemGroup/index.js 409 B
packages/main/dist/webComponents/ListItemStandard/index.js 473 B
packages/main/dist/webComponents/MediaGallery/index.js 834 B
packages/main/dist/webComponents/MediaGalleryItem/index.js 563 B
packages/main/dist/webComponents/Menu/index.js 823 B
packages/main/dist/webComponents/MenuItem/index.js 662 B
packages/main/dist/webComponents/MenuSeparator/index.js 359 B
packages/main/dist/webComponents/MessageStrip/index.js 813 B
packages/main/dist/webComponents/MultiComboBox/index.js 1.06 kB
packages/main/dist/webComponents/MultiComboBoxItem/index.js 326 B
packages/main/dist/webComponents/MultiComboBoxItemGroup/index.js 416 B
packages/main/dist/webComponents/MultiInput/index.js 676 B
packages/main/dist/webComponents/NavigationLayout/index.js 558 B
packages/main/dist/webComponents/NotificationList/index.js 714 B
packages/main/dist/webComponents/NotificationListGroupItem/index.js 631 B
packages/main/dist/webComponents/NotificationListItem/index.js 878 B
packages/main/dist/webComponents/Option/index.js 335 B
packages/main/dist/webComponents/OptionCustom/index.js 443 B
packages/main/dist/webComponents/Page/index.js 748 B
packages/main/dist/webComponents/Panel/index.js 1.19 kB
packages/main/dist/webComponents/Popover/index.js 677 B
packages/main/dist/webComponents/ProductSwitch/index.js 560 B
packages/main/dist/webComponents/ProductSwitchItem/index.js 531 B
packages/main/dist/webComponents/ProgressIndicator/index.js 449 B
packages/main/dist/webComponents/RadioButton/index.js 737 B
packages/main/dist/webComponents/RangeSlider/index.js 1.07 kB
packages/main/dist/webComponents/RatingIndicator/index.js 801 B
packages/main/dist/webComponents/ResponsivePopover/index.js 554 B
packages/main/dist/webComponents/SearchFieldScopeOption/index.js 338 B
packages/main/dist/webComponents/SegmentedButton/index.js 438 B
packages/main/dist/webComponents/SegmentedButtonItem/index.js 487 B
packages/main/dist/webComponents/Select/index.js 835 B
packages/main/dist/webComponents/ShellBar/index.js 781 B
packages/main/dist/webComponents/ShellBarItem/index.js 350 B
packages/main/dist/webComponents/ShellBarSpacer/index.js 426 B
packages/main/dist/webComponents/SideNavigation/index.js 1.05 kB
packages/main/dist/webComponents/SideNavigationGroup/index.js 415 B
packages/main/dist/webComponents/SideNavigationItem/index.js 432 B
packages/main/dist/webComponents/SideNavigationSubItem/index.js 431 B
packages/main/dist/webComponents/Slider/index.js 1.12 kB
packages/main/dist/webComponents/SortItem/index.js 313 B
packages/main/dist/webComponents/SpecialCalendarDate/index.js 413 B
packages/main/dist/webComponents/SplitButton/index.js 992 B
packages/main/dist/webComponents/StepInput/index.js 902 B
packages/main/dist/webComponents/SuggestionItem/index.js 329 B
packages/main/dist/webComponents/SuggestionItemCustom/index.js 482 B
packages/main/dist/webComponents/SuggestionItemGroup/index.js 411 B
packages/main/dist/webComponents/Switch/index.js 635 B
packages/main/dist/webComponents/Tab/index.js 415 B
packages/main/dist/webComponents/TabContainer/index.js 929 B
packages/main/dist/webComponents/Table/index.js 1.8 kB
packages/main/dist/webComponents/TableCell/index.js 464 B
packages/main/dist/webComponents/TableGrowing/index.js 786 B
packages/main/dist/webComponents/TableHeaderCell/index.js 545 B
packages/main/dist/webComponents/TableHeaderCellActionAI/index.js 388 B
packages/main/dist/webComponents/TableHeaderRow/index.js 495 B
packages/main/dist/webComponents/TableRow/index.js 443 B
packages/main/dist/webComponents/TableRowAction/index.js 373 B
packages/main/dist/webComponents/TableRowActionNavigation/index.js 389 B
packages/main/dist/webComponents/TableSelection/index.js 688 B
packages/main/dist/webComponents/TableSelectionMulti/index.js 572 B
packages/main/dist/webComponents/TableSelectionSingle/index.js 567 B
packages/main/dist/webComponents/TableVirtualizer/index.js 694 B
packages/main/dist/webComponents/TabSeparator/index.js 323 B
packages/main/dist/webComponents/Tag/index.js 592 B
packages/main/dist/webComponents/Text/index.js 673 B
packages/main/dist/webComponents/TextArea/index.js 512 B
packages/main/dist/webComponents/Timeline/index.js 583 B
packages/main/dist/webComponents/TimelineGroupItem/index.js 434 B
packages/main/dist/webComponents/TimelineItem/index.js 332 B
packages/main/dist/webComponents/TimePicker/index.js 1.21 kB
packages/main/dist/webComponents/Title/index.js 357 B
packages/main/dist/webComponents/Toast/index.js 543 B
packages/main/dist/webComponents/ToggleButton/index.js 623 B
packages/main/dist/webComponents/Token/index.js 349 B
packages/main/dist/webComponents/Tokenizer/index.js 863 B
packages/main/dist/webComponents/Toolbar/index.js 524 B
packages/main/dist/webComponents/ToolbarButton/index.js 456 B
packages/main/dist/webComponents/ToolbarSelect/index.js 503 B
packages/main/dist/webComponents/ToolbarSelectOption/index.js 370 B
packages/main/dist/webComponents/ToolbarSeparator/index.js 426 B
packages/main/dist/webComponents/ToolbarSpacer/index.js 431 B
packages/main/dist/webComponents/Tree/index.js 856 B
packages/main/dist/webComponents/TreeItem/index.js 490 B
packages/main/dist/webComponents/TreeItemCustom/index.js 580 B
packages/main/dist/webComponents/UploadCollection/index.js 454 B
packages/main/dist/webComponents/UploadCollectionItem/index.js 455 B
packages/main/dist/webComponents/UserMenu/index.js 543 B
packages/main/dist/webComponents/UserMenuAccount/index.js 404 B
packages/main/dist/webComponents/UserMenuItem/index.js 677 B
packages/main/dist/webComponents/UserSettingsDialog/index.js 484 B
packages/main/dist/webComponents/UserSettingsItem/index.js 554 B
packages/main/dist/webComponents/UserSettingsView/index.js 384 B
packages/main/dist/webComponents/ViewSettingsDialog/index.js 733 B
packages/main/dist/webComponents/Wizard/index.js 1.78 kB
packages/main/dist/webComponents/WizardStep/index.js 581 B

compressed-size-action

@coveralls
Copy link

coveralls commented Apr 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14259294916

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 87.517%
Totals Coverage Status
Change from base Build 14242982461: 0.02%
Covered Lines: 5132
Relevant Lines: 5864
💛 - Coveralls

@Lukas742 Lukas742 merged commit 1773d9d into main Apr 7, 2025
26 checks passed
@Lukas742 Lukas742 deleted the fix/toolbar-compat-spacer-separator-children branch April 7, 2025 08:39
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This PR is included in version v2.9.0 🎉

The release is available on v2.9.0

Your semantic-release bot 📦🚀

Lukas742 added a commit that referenced this pull request Apr 8, 2025
@Lukas742
fix(Toolbar - compat): prevent empty overflow popover (#7185)
d6325fd 
If only `ToolbarSeparator` or `ToolbarSpacer` components are passed to
the `Toolbar`, the components won't be rendered to prevent an empty
overflow popover to show up if the width of the Toolbar is very small.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusNotheis MarcusNotheis MarcusNotheis approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lukas742 @coveralls @ui5-webcomponents-react-bot @MarcusNotheis