Skip to content

fix: attach ui5-webcomponents event handlers before browser paint #7218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: attach ui5-webcomponents event handlers before browser paint #7218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/base/src/wrapper/withWebComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

const definedWebComponents = new Set<ComponentType>([]);

export const withWebComponent = <Props extends Record<string, any>, RefType = Ui5DomRef>(

Check warning on line 30 in packages/base/src/wrapper/withWebComponent.tsx

View workflow job for this annotation

GitHub Actions / lint 

Unexpected any. Specify a different type
tagName: string,
regularProperties: string[],
booleanProperties: string[],
Expand Down Expand Up @@ -188,9 +188,9 @@
}
}
});
}, [Component, ...propsToApply]);

Check warning on line 191 in packages/base/src/wrapper/withWebComponent.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook useEffect has missing dependencies: 'propsToApply' and 'ref'. Either include them or remove the dependency array

Check warning on line 191 in packages/base/src/wrapper/withWebComponent.tsx

View workflow job for this annotation

GitHub Actions / lint 

React Hook useEffect has a spread element in its dependency array. This means we can't statically verify whether you've passed the correct dependencies

useEffect(() => {
useIsomorphicLayoutEffect(() => {
setAttachEvents(true);
}, []);

Expand Down
Loading